ethtool netlink interface, part 3
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest15 patches 5 repliesIn review
- v115 patches 12 repliesSuperseded
Changes in v2 from the cover letter
- fix netdev reference leaks in error path of ethnl_set_rings() and ethnl_set_channels() (found by Jakub Kicinski)
- use __set_bit() rather than set_bit() (suggested by David Miller)
- in replies to RINGS_GET and CHANNELS_GET requests, omit ring and channel types not supported by driver/device (suggested by Jakub Kicinski)
- more descriptive message size calculations in rings_reply_size() and channels_reply_size() (suggested by Jakub Kicinski)
- coding style cleanup (suggested by Jakub Kicinski)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | ethtool: rename ethnl_parse_header() to ethnl_parse_header_dev_get()net/ net/ net/ +3 more | +25 | 0 replies | |
| 2/15 | ethtool: update mapping of features to legacy ioctl requestsnet/ | +3 | 0 replies | |
| 3/15 | ethtool: provide netdev features with FEATURES_GET requestDocumentation/ include/ net/ +5 more | +202 | 0 replies | |
| 4/15 | ethtool: add ethnl_parse_bitset() helpernet/ net/ | +98 | 0 replies | |
| 5/15 | ethtool: set netdev features with FEATURES_SET requestDocumentation/ include/ net/ +2 more | +224 | 0 replies | |
| 6/15 | ethtool: add FEATURES_NTF notificationDocumentation/ include/ net/ +1 more | +39 | 0 replies | |
| 7/15 | ethtool: provide private flags with PRIVFLAGS_GET requestDocumentation/ include/ net/ +3 more | +189 | 0 replies | |
| 8/15 | ethtool: set device private flags with PRIVFLAGS_SET requestDocumentation/ include/ net/ +2 more | +97 | 0 replies | |
| 9/15 | ethtool: add PRIVFLAGS_NTF notificationinclude/ net/ net/ +1 more | +8 | 0 replies | |
| 10/15 | ethtool: provide ring sizes with RINGS_GET requestDocumentation/ include/ net/ +3 more | +168 | 1 reply | |
| 11/15 | ethtool: set device ring sizes with RINGS_SET requestDocumentation/ include/ net/ +2 more | +118 | 1 reply | |
| 12/15 | ethtool: add RINGS_NTF notificationDocumentation/ include/ net/ +2 more | +12 | 0 replies | |
| 13/15 | ethtool: provide channel counts with CHANNELS_GET requestDocumentation/ include/ net/ +3 more | +169 | 1 reply | |
| 14/15 | ethtool: set device channel counts with CHANNELS_SET requestDocumentation/ include/ net/ +5 more | +177 | 1 reply | |
| 15/15 | ethtool: add CHANNELS_NTF notificationDocumentation/ include/ net/ +2 more | +12 | 0 replies |
Reviews trailers per patch
7 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Jakub Kicinski |
|---|---|
| 1/15 | |
| 2/15 | |
| 3/15 | R-b |
| 4/15 | |
| 5/15 | |
| 6/15 | |
| 7/15 | R-b |
| 8/15 | R-b |
| 9/15 | |
| 10/15 | R-b |
| 11/15 | R-b |
| 12/15 | |
| 13/15 | R-b |
| 14/15 | R-b |
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 00/15] ethtool netlink interface, part 3
Implementation of more netlink request types:
- netdev features (ethtool -k/-K, patches 3-6)
- private flags (--show-priv-flags / --set-priv-flags, patches 7-9)
- ring sizes (ethtool -g/-G, patches 10-12)
- channel counts (ethtool -l/-L, patches 13-15)
Patch 1 is a style cleanup suggested in part 2 review and patch 2 updates the mapping between netdev features and legacy ioctl requests (which are still used by ethtool for backward compatibility).
Changes in v2:
- fix netdev reference leaks in error path of ethnl_set_rings() and ethnl_set_channels() (found by Jakub Kicinski)
- use __set_bit() rather than set_bit() (suggested by David Miller)
- in replies to RINGS_GET and CHANNELS_GET requests, omit ring and channel types not supported by driver/device (suggested by Jakub Kicinski)
- more descriptive message size calculations in rings_reply_size() and channels_reply_size() (suggested by Jakub Kicinski)
- coding style cleanup (suggested by Jakub Kicinski)
Michal Kubecek (15):
ethtool: rename ethnl_parse_header() to ethnl_parse_header_dev_get()
ethtool: update mapping of features to legacy ioctl requests
ethtool: provide netdev features with FEATURES_GET request
ethtool: add ethnl_parse_bitset() helper
ethtool: set netdev features with FEATURES_SET request
ethtool: add FEATURES_NTF notification
ethtool: provide private flags with PRIVFLAGS_GET request
ethtool: set device private flags with PRIVFLAGS_SET request
ethtool: add PRIVFLAGS_NTF notification
ethtool: provide ring sizes with RINGS_GET request
ethtool: set device ring sizes with RINGS_SET request
ethtool: add RINGS_NTF notification
ethtool: provide channel counts with CHANNELS_GET request
ethtool: set device channel counts with CHANNELS_SET request
ethtool: add CHANNELS_NTF notification
Documentation/networking/ethtool-netlink.rst | 272 +++++++++++++++-- include/uapi/linux/ethtool_netlink.h | 82 +++++ net/ethtool/Makefile | 3 +- net/ethtool/bitset.c | 94 ++++++ net/ethtool/bitset.h | 4 + net/ethtool/channels.c | 227 ++++++++++++++ net/ethtool/common.c | 31 ++ net/ethtool/common.h | 3 + net/ethtool/debug.c | 6 +- net/ethtool/features.c | 304 +++++++++++++++++++ net/ethtool/ioctl.c | 52 +--- net/ethtool/linkinfo.c | 6 +- net/ethtool/linkmodes.c | 6 +- net/ethtool/netlink.c | 99 +++++- net/ethtool/netlink.h | 15 +- net/ethtool/privflags.c | 209 +++++++++++++ net/ethtool/rings.c | 200 ++++++++++++ net/ethtool/wol.c | 5 +- 18 files changed, 1538 insertions(+), 80 deletions(-) create mode 100644 net/ethtool/channels.c create mode 100644 net/ethtool/features.c create mode 100644 net/ethtool/privflags.c create mode 100644 net/ethtool/rings.c
Signature · 1 line
2.25.1