Skip to content

staging: fbtft: code cleanup patchset - checkpatch

Deepak R Varma outreachy 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesIn review
  2. v24 patches 4 repliesSuperseded
  3. v14 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Implement Corrections suggested by Stefano for [patch 1/4, 2/4, 3/4]:
1. Typos in patch description.
2. Improve variable name as per coding style guidelines.
- Advised following for Patch 4/4
1. Reviewed-by: Stefano Brivio <[email protected]>

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: fbtft: Reformat line over 80 charactersdrivers/staging/fbtft/fbtft-core.c+3 -10 replies
2/4staging: fbtft: Reformat long macro definitionsdrivers/staging/fbtft/fbtft.h+11 -30 replies
3/4staging: fbtft: simplify array index computationdrivers/staging/fbtft/fbtft-sysfs.c+5 -10 replies
4/4staging: fbtft: Avoid potential precedence issuesdrivers/staging/fbtft/fbtft.h+2 -25 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchStefano Brivio
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] staging: fbtft: code cleanup patchset - checkpatch

Implement code formatting corrections as flagged by checkpatch script. Common issues around lines exceeding 80 column limit and similar formatting issues for the fbtft driver files are considered in the scope of this patchset.

Note that top two patches in the list below were sent to the mailing list for review as individual patches earlier. As I found additional similar issues in the same area, I am requesting to combine these related patches in this patchset.

Changes since v2:
- Implement Corrections suggested by Stefano for [patch 1/4, 2/4, 3/4]:
1. Typos in patch description.
2. Improve variable name as per coding style guidelines.
- Advised following for Patch 4/4
1. Reviewed-by: Stefano Brivio <[email protected]>

Changes since v1:
- Corrections suggested by Julia for [patch 4 /4]:
1. Update commit message - use word "potential" in place of "likely".
2. Update log message - use word "parentheses" in place of "braces".
3. Rephrase log message - make it concise and easy to understand.

Deepak R Varma (4):
staging: fbtft: Reformat line over 80 characters
staging: fbtft: Reformat long macro definitions
staging: fbtft: simplify array index computation
staging: fbtft: Avoid potential precedence issues

 drivers/staging/fbtft/fbtft-core.c  |  4 +++-
 drivers/staging/fbtft/fbtft-sysfs.c |  6 +++++-
 drivers/staging/fbtft/fbtft.h       | 18 +++++++++++++-----
 3 files changed, 21 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.1