Skip to content

Misc hw/ide legacy clean up

BALATON Zoltan qemu-devel 3 versions – Applied

Status from this message: Thanks, applied to my IDE tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 5 repliesApplied
  2. v27 patches 12 repliesSuperseded
  3. v18 patches 22 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8hw/ide: Get rid of piix3_init functionshw/i386/pc_piix.c hw/ide/pci.c hw/ide/piix.c +1 more+7 -270 replies
2/8hw/isa/piix4.c: Introduce variable to store devfnhw/isa/piix4.c+7 -51 reply
3/8hw/ide: Get rid of piix4_init functionhw/ide/piix.c hw/isa/piix4.c include/hw/ide.h+4 -130 replies
4/8hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.hhw/ide/ahci_internal.h include/hw/ide.h include/hw/ide/pci.h +1 more+3 -10 replies
5/8hw/ide/pci.c: Coding style update to fix checkpatch errorshw/ide/pci.c+3 -30 replies
6/8hw/ide: Do ide_drive_get() within pci_ide_create_devs()hw/alpha/dp264.c hw/i386/pc_piix.c hw/ide/pci.c +6 more+18 -350 replies
7/8hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.hhw/mips/mips_r4k.c include/hw/ide.h include/hw/ide/internal.h+3 -20 replies
8/8hw/ide: Remove unneeded inclusion of hw/ide.hhw/hppa/hppa_sys.h hw/hppa/machine.c hw/i386/pc_piix.c +5 more+0 -80 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMark Cave-AylandMarkus ArmbrusterPhilippe Mathieu-Daudé
1/8R-b R-b R-b
2/8R-b
3/8R-b R-b
4/8R-b R-b R-b
5/8R-b R-b R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] Misc hw/ide legacy clean up

Avoid problems from reassigning variable in piix4_create and fix compilation problem with mips_r4k

BALATON Zoltan (8):
hw/ide: Get rid of piix3_init functions hw/isa/piix4.c: Introduce variable to store devfn hw/ide: Get rid of piix4_init function
hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h hw/ide/pci.c: Coding style update to fix checkpatch errors hw/ide: Do ide_drive_get() within pci_ide_create_devs() hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h hw/ide: Remove unneeded inclusion of hw/ide.h

 hw/alpha/dp264.c              | 13 +++----------
 hw/hppa/hppa_sys.h            |  1 -
 hw/hppa/machine.c             |  1 -
 hw/i386/pc_piix.c             | 18 +++++++++---------
 hw/ide/ahci_internal.h        |  1 +
 hw/ide/pci.c                  | 11 +++++++----
 hw/ide/piix.c                 | 31 +------------------------------
 hw/isa/piix4.c                | 23 ++++++++++-------------
 hw/mips/mips_fulong2e.c       |  5 +----
 hw/mips/mips_malta.c          |  2 +-
 hw/mips/mips_r4k.c            |  1 +
 hw/ppc/mac_newworld.c         |  1 -
 hw/ppc/mac_oldworld.c         |  1 -
 hw/ppc/prep.c                 |  1 -
 hw/sparc64/sun4u.c            |  6 +-----
 include/hw/ide.h              |  6 ------
 include/hw/ide/internal.h     |  2 ++
 include/hw/ide/pci.h          |  3 ++-
 include/hw/misc/macio/macio.h |  1 +
 include/hw/southbridge/piix.h |  3 +--
 20 files changed, 41 insertions(+), 90 deletions(-)
Signature · 1 line
2.21.1