Skip to content

dir: update outdated field names and comments about oid_stat

Matheus Tavares git 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Renamed "ss_info_exclude" and "ss_excludes_file" to "info_exclude_validity" and "excludes_file_validity", as suggested by Junio.
- Added patch 3, addressing outdated comments' updates on dir.h, as suggested by Patryk.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dir: fix outdated comment on add_patterns()dir.c+4 -30 replies
2/3dir: improve naming of oid_stat fields in two structsdir.c dir.h t/helper/test-dump-untracked-cache.c+27 -200 replies
3/3dir: update outdated comments about untracked cachedir.c dir.h+6 -40 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchJunio C Hamano
1/3
2/3Helped-by
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] dir: update outdated field names and comments about oid_stat

In 4b33e60 ("dir: convert struct sha1_stat to use object_id", 2018-01-28), we renamed "struct sha1_stat" to "struct oid_stat". However, there are still some comments and struct field names which refer to the old sha1_stat. The patches in this series update those places.

Changes since v1:
- Renamed "ss_info_exclude" and "ss_excludes_file" to "info_exclude_validity" and "excludes_file_validity", as suggested by Junio.
- Added patch 3, addressing outdated comments' updates on dir.h, as suggested by Patryk.

Matheus Tavares (3):
dir: fix outdated comment on add_patterns()
dir: improve naming of oid_stat fields in two structs
dir: update outdated comments about untracked cache

 dir.c                                | 44 ++++++++++++++++------------
 dir.h                                | 15 +++++-----
 t/helper/test-dump-untracked-cache.c |  5 ++--
 3 files changed, 37 insertions(+), 27 deletions(-)
Signature · 1 line
2.25.1