Skip to content

staging: iio: adc: General code reformatting / cleanup patchset

Deepak R Varma linux-iio outreachy 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 18 repliesIn review
  2. v23 patches 4 repliesSuperseded
  3. v12 patches 25 repliesSuperseded

Changes in v3 from the cover letter

1. Add new patch to the series for ad7280a driver to add comments near code that flags a misleading checkpatch warning.
2. Add patch version number v3 in individual patch subject lines.
3. Simplified current implementation of function get_filter_freq per advice from Stefano.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: iio: adc: ad7192: Re-indent enum labelsdrivers/iio/adc/ad7192.c+2 -23 replies
2/4staging: iio: adc: ad7192: Correct macro names from SYNC to SINCdrivers/iio/adc/ad7192.c+10 -103 replies
3/4staging: iio: adc: ad7192: get_filter_freq code optimizationdrivers/iio/adc/ad7192.c+6 -1110 replies
4/4staging: iio: adc: ad7280a: Add comments to clarify stringified argumentsdrivers/staging/iio/adc/ad7280a.c+4 -02 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchAlexandru Ardelean
1/4R-b R-b
2/4R-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] staging: iio: adc: General code reformatting / cleanup patchset

Address code formatting warnings and check messages flagged by checkpatch script. Includes improvement for correcting macro name typos and simplified function implementation. Changes intended to improve readability of code.

Changes since v2:
1. Add new patch to the series for ad7280a driver to add comments near code that flags a misleading checkpatch warning.
2. Add patch version number v3 in individual patch subject lines.
3. Simplified current implementation of function get_filter_freq per advice from Stefano.

Changes since v1:
1. Add separate patch for code re-indentation comment
2. Add separate patch for correcting macro names as suggested by Lars-Peter.
3. Update variable name from sync* to sinc* as suggested by Stefano.
4. Revert patch intended to add space around "-" operator. It was a string with a "-" sign further formatted using stringification. That patch is out of the patchset now.

Deepak R Varma (4):
staging: iio: adc: ad7192: Re-indent enum labels
staging: iio: adc: ad7192: Correct macro names from SYNC to SINC
staging: iio: adc: ad7192: get_filter_freq code optimization
staging: iio: adc: ad7280a: Add comments to clarify stringified
arguments

 drivers/iio/adc/ad7192.c          | 37 +++++++++++++------------------
 drivers/staging/iio/adc/ad7280a.c |  4 ++++
 2 files changed, 20 insertions(+), 21 deletions(-)
Signature · 1 line
2.17.1