Skip to content

serial: uartps: Add TACTIVE check

Shubhrajyoti Datta linux-arm-kernel linux-serial 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest2 patches 1 replyIn review

Changes in v4 from the cover letter

-Split into two patches as suggested by Johan

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2serial: uartps: Remove unconditional wait inside set_termiosdrivers/tty/serial/xilinx_uartps.c+2 -140 replies
2/2serial: uartps: Add TACTIVE check in cdns_uart_tx_empty functiondrivers/tty/serial/xilinx_uartps.c+2 -21 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMaarten Brock
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] serial: uartps: Add TACTIVE check

The cdns_uart_tx_empty function is currently checking oly for tx_empty bit of SR. In some environments, it is leading to a corruption in log because tx_empty does not gaurantee that all the bytes are transmitted out of the FIFO. So, add TACTIVE bit in the check.

This patch series does the following:
-Remove unconditional wait for tx_empty inside set_termios function -Add TACTIVE check in cdns_uart_tx_empty function

Changes in v4:
-Split into two patches as suggested by Johan

Raviteja Narayanam (2):
serial: uartps: Remove unconditional wait inside set_termios
serial: uartps: Add TACTIVE check in cdns_uart_tx_empty function

 drivers/tty/serial/xilinx_uartps.c | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)
Signature · 1 line
2.1.1