Skip to content

WriteBooster Feature Support

Asutosh Das linux-arm-msm linux-scsi lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/23 patches 1 replyIn review
  2. v1 posting 1/23 patches 4 repliesSuperseded

v1 -> v2 from the cover letter

- Addressed comments on v1

- Supports shared buffer mode only

- Didn't use exception event as suggested.
The reason being while testing I saw that the WriteBooster available buffer remains at 0x1 for a longer time if flush is enabled all the time as compared to an event-based enablement. This essentially means that writes go to the WriteBooster buffer more. Spec says that the if flush is enabled, the device would flush when it sees the command queue empty. So I guess that'd trigger flush more than an event based approach.
Anyway the Vcc would be turned-off during system suspend, so flush would stop anyway.
In this patchset, I never turn-off flush.
Hence the RFC.

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3scsi: ufs: add write booster feature supportdrivers/scsi/ufs/ufs.h drivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+273 -50 replies
2/3ufs-qcom: scsi: configure write booster typedrivers/scsi/ufs/ufs-qcom.c+7 -00 replies
3/3ufs: sysfs: add sysfs entries for write boosterdrivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufs.h+44 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [<RFC RESEND PATCH v2> 0/3] WriteBooster Feature Support

Still a RFC patch, because I'm still expecting some comments on the design.

v1 -> v2:
- Addressed comments on v1

- Supports shared buffer mode only

- Didn't use exception event as suggested.
The reason being while testing I saw that the WriteBooster available buffer remains at 0x1 for a longer time if flush is enabled all the time as compared to an event-based enablement. This essentially means that writes go to the WriteBooster buffer more. Spec says that the if flush is enabled, the device would flush when it sees the command queue empty. So I guess that'd trigger flush more than an event based approach.
Anyway the Vcc would be turned-off during system suspend, so flush would stop anyway.
In this patchset, I never turn-off flush.
Hence the RFC.

Asutosh Das (3):
scsi: ufs: add write booster feature support
ufs-qcom: scsi: configure write booster type
ufs: sysfs: add sysfs entries for write booster

 drivers/scsi/ufs/ufs-qcom.c  |   7 ++
 drivers/scsi/ufs/ufs-sysfs.c |  39 ++++++-
 drivers/scsi/ufs/ufs.h       |  37 ++++++-
 drivers/scsi/ufs/ufshcd.c    | 238 ++++++++++++++++++++++++++++++++++++++++++-
 drivers/scsi/ufs/ufshcd.h    |   9 ++
 5 files changed, 324 insertions(+), 6 deletions(-)
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.