Skip to content

Staging: speakup: Misc cleanups and code reformatting.

Sam Muhammed outreachy 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 2 repliesSuperseded
  3. v13 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Adding Reviewed-by: Samuel Thibault <[email protected]> for both patches.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Staging: speakup: Use sizeof(*var) in kmalloc().drivers/staging/speakup/spk_ttyio.c+1 -10 replies
2/2Staging: speakup: Add identifier name to function declaration arguments.drivers/staging/speakup/spk_types.h+1 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSamuel Thibault
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Staging: speakup: Misc cleanups and code reformatting.

Changes to clear Checkpatch.pl CHECKs of proper use of kmalloc(), and adding identifier names to function declaration arguments.

All modifications made to match coding style and
to improve readability.

Changes in v3:
- Adding Reviewed-by: Samuel Thibault <[email protected]> for both patches.

Changes in v2:
- Drop the first patch in the previous version:
Staging: speakup: Avoid multiple assignments.
This code is better with multiple assignments.

Sam Muhammed (2):
Staging: speakup: Use sizeof(*var) in kmalloc().
Staging: speakup: Add identifier name to function declaration
arguments.

 drivers/staging/speakup/spk_ttyio.c | 2 +-
 drivers/staging/speakup/spk_types.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

---
2.20.1