Skip to content

Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS.

Sam Muhammed outreachy 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 12 repliesIn review
  2. v16 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Adding a new patch to the series:
Patch #6: Use kcalloc over kzalloc.
- Recovering alignment of code that a patch messed up in the previous revision:
Patch #7: Use spaces around operators.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Staging: kpc2000: kpc_dma: Remove comparison to NULL.drivers/staging/kpc2000/kpc_dma/dma.c drivers/staging/kpc2000/kpc_dma/fileops.c drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h+9 -96 replies
2/7Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().drivers/staging/kpc2000/kpc_dma/fileops.c drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c+2 -25 replies
3/7Staging: kpc2000: kpc_dma: Remove unnecessary braces.drivers/staging/kpc2000/kpc_dma/dma.c drivers/staging/kpc2000/kpc_dma/fileops.c drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c+12 -160 replies
4/7Staging: kpc2000: kpc_dma: Include the preferred header.drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c+1 -10 replies
5/7Staging: kpc2000: kpc_dma: Use the SPDK comment style.drivers/staging/kpc2000/kpc_dma/dma.c drivers/staging/kpc2000/kpc_dma/fileops.c drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c+3 -30 replies
6/7Staging: kpc2000: kpc_dma: Use kcalloc over kzalloc.drivers/staging/kpc2000/kpc_dma/fileops.c+2 -10 replies
7/7Staging: kpc2000: kpc_dma: Use spaces around operators.drivers/staging/kpc2000/kpc_dma/fileops.c+7 -70 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefano Brivio
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS.

This driver has multiple WARNINGS and CHECKS, Changes been made to match coding style and standards. Modifications:
- Remove Comparison to NULL.
- Proper usage of kzalloc().
- Reformat single statement blocks.
- Including preferred header.
- Using the proper SPDK comment style.
- Using kcalloc instead of kzalloc with multiply.
- Putting spaces around operators.

Changes in v2:
- Adding a new patch to the series:
Patch #6: Use kcalloc over kzalloc.
- Recovering alignment of code that a patch messed up in the previous revision:
Patch #7: Use spaces around operators.

Sam Muhammed (7):
Staging: kpc2000: kpc_dma: Remove comparison to NULL.
Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().
Staging: kpc2000: kpc_dma: Remove unnecessary braces.
Staging: kpc2000: kpc_dma: Include the preferred header.
Staging: kpc2000: kpc_dma: Use the SPDK comment style.
Staging: kpc2000: kpc_dma: Use kcalloc over kzalloc.
Staging: kpc2000: kpc_dma: Use spaces around operators.

 drivers/staging/kpc2000/kpc_dma/dma.c         |  9 ++--
 drivers/staging/kpc2000/kpc_dma/fileops.c     | 49 +++++++++----------
 .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  |  9 ++--
 .../staging/kpc2000/kpc_dma/kpc_dma_driver.h  |  4 +-
 4 files changed, 34 insertions(+), 37 deletions(-)

---
2.20.1