Skip to content

Staging: rtl8192u: ieee80211: Replace printk(KERN_<LEVEL> ...) with netdev_*() family.

Sam Muhammed outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Staging: rtl8192u: ieee80211: Use netdev_dbg() for debug messages.drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c+12 -143 replies
2/4Staging: rtl8192u: ieee80211: Use netdev_warn() for network devices.drivers/staging/rtl8192u/ieee80211/ieee80211_module.c drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c+10 -150 replies
3/4Staging: rtl8192u: ieee80211: Use netdev_info() with network devices.drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c+20 -160 replies
4/4Staging: rtl8192u: ieee80211: Use netdev_alert().drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Staging: rtl8192u: ieee80211: Replace printk(KERN_<LEVEL> ...) with netdev_*() family.

Use the netdev_*() family across the driver, since it's specific for network devices and already been used in multiple cases. This series replaces the rest.
Checkpatch.pl: WARNINGS:

Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...

Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

Prefer [subsystem eg: netdev]_alert([subsystem]dev, ... then dev_alert(dev, ... then pr_alert(... to printk(KERN_ALERT ...

Sam Muhammed (4):
Staging: rtl8192u: ieee80211: Use netdev_dbg() for debug messages.
Staging: rtl8192u: ieee80211: Use netdev_warn() for network devices.
Staging: rtl8192u: ieee80211: Use netdev_info() with network devices.
Staging: rtl8192u: ieee80211: Use netdev_alert().

 .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 19 ++++++------
 .../rtl8192u/ieee80211/ieee80211_module.c     |  3 +-
 .../rtl8192u/ieee80211/ieee80211_softmac.c    | 30 +++++++++++--------
 .../rtl8192u/ieee80211/ieee80211_softmac_wx.c |  4 +--
 .../staging/rtl8192u/ieee80211/ieee80211_tx.c | 26 +++++++---------
 .../staging/rtl8192u/ieee80211/ieee80211_wx.c |  7 ++---
 6 files changed, 43 insertions(+), 46 deletions(-)

---
2.20.1