Skip to content

Implement stats_update callback for pedit and skbedit

Petr Machata netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sched: act_skbedit: Implement stats_update callbacknet/sched/act_skbedit.c+11 -00 replies
2/3sched: act_pedit: Implement stats_update callbacknet/sched/act_pedit.c+11 -00 replies
3/3selftests: skbedit_priority: Test counters at the skbedit ruletools/testing/selftests/net/forwarding/skbedit_priority.sh+7 -20 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchAlexander Petrovskiy
SeriesT-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] Implement stats_update callback for pedit and skbedit

The stats_update callback is used for adding HW counters to the SW ones. Both skbedit and pedit actions are actually recognized by flow_offload.h, but do not implement these callbacks. As a consequence, the reported values are only the SW ones, even where there is a HW counter available.

Patch #1 adds the callback to action skbedit, patch #2 adds it to action pedit. Patch #3 tweaks an skbedit selftest with a check that would have caught this problem.

The pedit test is not likewise tweaked, because the iproute2 pedit action currently does not support JSON dumping. This will be addressed later.

Petr Machata (3):
sched: act_skbedit: Implement stats_update callback
sched: act_pedit: Implement stats_update callback
selftests: skbedit_priority: Test counters at the skbedit rule

 net/sched/act_pedit.c                                 | 11 +++++++++++
 net/sched/act_skbedit.c                               | 11 +++++++++++
 .../selftests/net/forwarding/skbedit_priority.sh      |  9 +++++++--
 3 files changed, 29 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1