Skip to content

ethtool netlink interface, part 4

Michal Kubecek lkml netdev 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 2 repliesIn review
  2. v212 patches 4 repliesSuperseded
  3. v112 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- change "one-step-*" Tx type names to "onestep-*", (patch 11, suggested by Richard Cochran
- use "TSINFO" rather than "TIMESTAMP" for timestamping information constants and adjust symbol names (patch 12, suggested by Richard Cochran)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ethtool: fix reference leak in ethnl_set_privflags()net/ethtool/privflags.c+3 -10 replies
2/12ethtool: provide coalescing parameters with COALESCE_GET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/Makefile +3 more+306 -20 replies
3/12ethtool: set coalescing parameters with COALESCE_SET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/coalesce.c +2 more+184 -10 replies
4/12ethtool: add COALESCE_NTF notificationDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/coalesce.c +2 more+12 -10 replies
5/12ethtool: provide pause parameters with PAUSE_GET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/Makefile +3 more+146 -20 replies
6/12ethtool: set pause parameters with PAUSE_SET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/netlink.c +2 more+70 -10 replies
7/12ethtool: add PAUSE_NTF notificationDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/ioctl.c +2 more+12 -10 replies
8/12ethtool: provide EEE settings with EEE_GET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/Makefile +3 more+192 -20 replies
9/12ethtool: set EEE settings with EEE_SET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/eee.c +2 more+104 -10 replies
10/12ethtool: add EEE_NTF notificationDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/eee.c +2 more+12 -10 replies
11/12ethtool: add timestamping related string setsinclude/uapi/linux/ethtool.h include/uapi/linux/net_tstamp.h net/core/dev_ioctl.c +3 more+87 -00 replies
12/12ethtool: provide timestamping information with TSINFO_GET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/Makefile +6 more+225 -210 replies

Reviews trailers per patch

5 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJakub KicinskiRichard CochranJiri Pirko
SeriesA-b
1/12
2/12R-b
3/12R-b
4/12R-b
5/12
6/12
7/12
8/12
9/12
10/12
11/12A-b
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 00/12] ethtool netlink interface, part 4

Implementation of more netlink request types:

- coalescing (ethtool -c/-C, patches 2-4)
- pause parameters (ethtool -a/-A, patches 5-7)
- EEE settings (--show-eee / --set-eee, patches 8-10)
- timestamping info (-T, patches 11-12)

Patch 1 is a fix for netdev reference leak similar to commit 2f599ec422ad ("ethtool: fix reference leak in some *_SET handlers") but fixing a code

Changes in v3
- change "one-step-*" Tx type names to "onestep-*", (patch 11, suggested by Richard Cochran
- use "TSINFO" rather than "TIMESTAMP" for timestamping information constants and adjust symbol names (patch 12, suggested by Richard Cochran)

Changes in v2:
- fix compiler warning in net_hwtstamp_validate() (patch 11)
- fix follow-up lines alignment (whitespace only, patches 3 and 8)
which is only in net-next tree at the moment.

Michal Kubecek (12):
ethtool: fix reference leak in ethnl_set_privflags()
ethtool: provide coalescing parameters with COALESCE_GET request
ethtool: set coalescing parameters with COALESCE_SET request
ethtool: add COALESCE_NTF notification
ethtool: provide pause parameters with PAUSE_GET request
ethtool: set pause parameters with PAUSE_SET request
ethtool: add PAUSE_NTF notification
ethtool: provide EEE settings with EEE_GET request
ethtool: set EEE settings with EEE_SET request
ethtool: add EEE_NTF notification
ethtool: add timestamping related string sets
ethtool: provide timestamping information with TSINFO_GET request

 Documentation/networking/ethtool-netlink.rst | 225 +++++++++++-
 include/uapi/linux/ethtool.h                 |   6 +
 include/uapi/linux/ethtool_netlink.h         |  93 +++++
 include/uapi/linux/net_tstamp.h              |   6 +
 net/core/dev_ioctl.c                         |   6 +
 net/ethtool/Makefile                         |   2 +-
 net/ethtool/coalesce.c                       | 353 +++++++++++++++++++
 net/ethtool/common.c                         |  70 ++++
 net/ethtool/common.h                         |   6 +
 net/ethtool/eee.c                            | 206 +++++++++++
 net/ethtool/ioctl.c                          |  41 +--
 net/ethtool/netlink.c                        |  53 +++
 net/ethtool/netlink.h                        |   7 +
 net/ethtool/pause.c                          | 145 ++++++++
 net/ethtool/privflags.c                      |   4 +-
 net/ethtool/strset.c                         |  15 +
 net/ethtool/tsinfo.c                         | 143 ++++++++
 17 files changed, 1350 insertions(+), 31 deletions(-)
 create mode 100644 net/ethtool/coalesce.c
 create mode 100644 net/ethtool/eee.c
 create mode 100644 net/ethtool/pause.c
 create mode 100644 net/ethtool/tsinfo.c
Signature · 1 line
2.25.1