Skip to content

staging: rtl8712: rtl871x_xmit.{c,h} code style improvements

Aiman Najjar lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 2 repliesIn review
  2. v25 patches 5 repliesSuperseded

Changes in v3 from the cover letter

* [PATCH 4/5]: Applied suggestions by Joe to improve overall code quality (thanks Joe!)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: rtl8712: fix checkpatch long-line warningdrivers/staging/rtl8712/rtl871x_xmit.c+3 -20 replies
2/5staging: rtl8712: fix long-line checkpatch warningdrivers/staging/rtl8712/rtl871x_xmit.c+2 -20 replies
3/5staging: rtl8712: fix checkpatch warningsdrivers/staging/rtl8712/rtl871x_xmit.c+7 -80 replies
4/5staging:rtl8712: code improvements to make_wlanhdrdrivers/staging/rtl8712/rtl871x_xmit.c drivers/staging/rtl8712/rtl871x_xmit.h+61 -640 replies
5/5staging: rtl8712:fix multiline derefernce warningsdrivers/staging/rtl8712/rtl871x_xmit.c+4 -70 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements

Make several improvements to code style of rtl871x_xmit.c and rtl871x_xmit.h.

v1 -> v2: changes
* Break up single pach into patchset of small patches

v2 -> v3 changes:
* [PATCH 4/5]: Applied suggestions by Joe to improve overall code quality (thanks Joe!)

Aiman Najjar (5):
staging: rtl8712: fix checkpatch long-line warning
staging: rtl8712: fix long-line checkpatch warning
staging: rtl8712: fix checkpatch warnings staging:rtl8712: code improvements to make_wlanhdr
staging: rtl8712:fix multiline derefernce warnings

 drivers/staging/rtl8712/rtl871x_xmit.c | 158 ++++++++++++-------------
 drivers/staging/rtl8712/rtl871x_xmit.h |   2 +-
 2 files changed, 77 insertions(+), 83 deletions(-)
Signature · 1 line
2.20.1