Skip to content

Staging: vt6655: Remove unused functions.

Briana Oursler outreachy 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyIn review
  2. v33 patches 4 repliesSuperseded
  3. v23 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches4 repliesSuperseded

Changes in v4 from the cover letter

- Update patch series title.
- Add patch 4/4 per suggestion of Julia Lawall.
- Patches 1/4-3/4 unchanged.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Staging: vt6655: Remove CARDbSoftwareReset definition.drivers/staging/vt6655/card.c drivers/staging/vt6655/card.h+0 -220 replies
2/4Staging: vt6655: Remove CARDvSetLoopbackMode definition.drivers/staging/vt6655/card.c drivers/staging/vt6655/card.h+0 -310 replies
3/4Staging: vt6655: Remove CARDbRadioPowerOn definition.drivers/staging/vt6655/card.c drivers/staging/vt6655/card.h+0 -560 replies
4/4Staging: vt6655: Remove BBvExitDeepSleep definition.drivers/staging/vt6655/baseband.c drivers/staging/vt6655/baseband.h+0 -70 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefano Brivio
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Patch v4 0/4] Staging: vt6655: Remove unused functions.

This patchset removes functions that are not called in the driver but are prototyped in card.h. Each commit limits its scope to one function definition and related documentation in code.

Functions were checked for calls using the Elixir Cross Referencer and git grep.

Per Stefano Brivio's recommendation, output of bloatometer script after changes:

add/remove: 0/4 grow/shrink: 0/0 up/down: 0/-572 (-572)
Function old new delta

CARDbSoftwareReset                            10       -     -10
CARDvSetLoopbackMode                          14       -     -14
BBvExitDeepSleep                              40       -     -40
CARDbRadioPowerOn                            508       -    -508

Total: Before=36131, After=35559, chg -1.58%

Briana Oursler (4):
Staging: vt6655: Remove CARDbSoftwareReset definition.
Staging: vt6655: Remove CARDvSetLoopbackMode definition.
Staging: vt6655: Remove CARDbRadioPowerOn definition.
Staging: vt6655: Remove BBvExitDeepSleep definition.

Changes in v4:
- Update patch series title.
- Add patch 4/4 per suggestion of Julia Lawall.
- Patches 1/4-3/4 unchanged.

Changes in v3:
- Update language in patch series name at suggestions from Stefano Brivio and Julia Lawall.
- Remove references to the changelog in the cover letter. It is unrelated to this series.

Changes in v2:
- Add output of bloatometer.
- Change language from "uncalled function" to "function...that is never called" in each patch description within the series.

 drivers/staging/vt6655/baseband.c |   6 --
 drivers/staging/vt6655/baseband.h |   1 -
 drivers/staging/vt6655/card.c     | 105 ------------------------------
 drivers/staging/vt6655/card.h     |   4 --
 4 files changed, 116 deletions(-)
Signature · 1 line
2.24.1