Skip to content

Staging: vt6655: Simplify statement logic.

Briana Oursler outreachy 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 4 repliesSuperseded
  3. v14 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Patch 1/4 - 3/4:
- Substance unchanged, add Reviewed-by tag from Stefano Brivio.
- Patch 4/4:
- Add curly brackets per recommendation of Stefano Brivio.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Staging: vt6655: Limit return statements.drivers/staging/vt6655/rxtx.c+9 -200 replies
2/4Staging: vt6655: Move rate determination logic.drivers/staging/vt6655/rxtx.c+10 -200 replies
3/4Staging: vt6655: Eliminate nested if elsedrivers/staging/vt6655/rxtx.c+14 -290 replies
4/4Staging: vt6655: Format long lines.drivers/staging/vt6655/rxtx.c+38 -130 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefano Brivio
SeriesR-b
1/4R-b
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Patch v3 0/4] Staging: vt6655: Simplify statement logic.

Reduce code duplication and complexity within switch case statement. The goal is to improve the readability of the statement so that the outcome of the statement is more clear. Checkpatch identified long lines and other formatting issues within some nested logic. The last commit in this patch series addresses checkpatch warnings that were not fixed by other means within the series. Some long lines were left under the rationale that removing them rendered the output more confusing.

Briana Oursler (4):
Staging: vt6655: Limit return statements.
Staging: vt6655: Move rate determination logic.
Staging: vt6655: Eliminate nested if else
Staging: vt6655: Format long lines.

Changes in v3:
- Patch 1/4 - 3/4:
- Substance unchanged, add Reviewed-by tag from Stefano Brivio.
- Patch 4/4:
- Add curly brackets per recommendation of Stefano Brivio.

Changes in v2:
- Patch 1/4:
- Per Stefano Brivio's recommendation, remove curly braces and unnecessary else clause.
- Remove unrelated newline.
- Patch 2/4:
- Remove unrelated newline.
- Change to a clearer patch subject and description per Stefano Brivio.
- Patch 3/4:
- Avoid beginning commit description with solution, per Stefano Brivio's advice.
- Move declaration of len to the same line as other unsigned ints declared in the same scope, change recommended by Stefano Brivio.
- Remove unrelated newlines.
- Patch 4/4:
- Change patch subject and description to better describe change, per Stefano Brivio.

 drivers/staging/vt6655/rxtx.c | 119 +++++++++++++++-------------------
 1 file changed, 54 insertions(+), 65 deletions(-)
Signature · 1 line
2.24.1