Skip to content

colo-compare bugfixes

Lukas Straub qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 1 replyIn review
  2. v56 patches 1 replySuperseded
  3. v46 patches 23 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches5 repliesSuperseded
v26 patches0 repliesSuperseded
v13 patches11 repliesSuperseded

Changes in v6 from the cover letter

-don't touch softmmu/vl.c, use __contructor__ attribute instead -better wording

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net/colo-compare.c: Create event_bh with the right AioContextnet/colo-compare.c+2 -10 replies
2/6chardev/char.c: Use qemu_co_sleep_ns if in coroutinechardev/char.c+6 -10 replies
3/6net/colo-compare.c: Fix deadlock in compare_chr_sendnet/colo-compare.c net/colo.c net/colo.h+156 -450 replies
4/6net/colo-compare.c: Only hexdump packets if tracing is enablednet/colo-compare.c+6 -40 replies
5/6net/colo-compare.c: Check that colo-compare is activenet/colo-compare.c+29 -61 reply
6/6net/colo-compare.c: Correct ordering in complete and finalizenet/colo-compare.c+23 -220 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchZhang ChenDerek SuPhilippe Mathieu-DaudéMarc-André LureauLukas Straub
1/6R-b R-b T-b
2/6R-b R-b R-b
3/6R-b T-b
4/6R-b R-b T-b
5/6R-b T-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/6] colo-compare bugfixes

Hello Everyone,
Here are fixes for bugs that I found in my tests. I have tested this with my test suite and everything works fine.

Regards,
Lukas Straub

Version changes:
v6:
-don't touch softmmu/vl.c, use __contructor__ attribute instead -better wording

v5:
-initialize and use notify_sendco only if notify_dev is set

v4:
-fix potential deadlock with notify_remote_frame
-avoid malloc and memcpy in many cases

v3:
-fix checkpatch.pl error

v2:
-better wording
-fix performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in compare_chr_send" -add more bugfixes

Lukas Straub (6):
net/colo-compare.c: Create event_bh with the right AioContext chardev/char.c: Use qemu_co_sleep_ns if in coroutine net/colo-compare.c: Fix deadlock in compare_chr_send net/colo-compare.c: Only hexdump packets if tracing is enabled net/colo-compare.c: Check that colo-compare is active net/colo-compare.c: Correct ordering in complete and finalize

 chardev/char.c     |   7 +-
 net/colo-compare.c | 254 ++++++++++++++++++++++++++++++++++-----------
 net/colo.c         |   7 ++
 net/colo.h         |   1 +
 4 files changed, 206 insertions(+), 63 deletions(-)

--
2.20.1