Skip to content

Remove setup_percpu_irq() & remove_percpu_irq

afzal mohammed linux-mips lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3MIPS: Replace setup_percpu_irq() by request_percpu_irq() variantarch/mips/include/asm/cevt-r4k.h arch/mips/kernel/cevt-r4k.c arch/mips/sgi-ip27/ip27-timer.c +1 more+8 -230 replies
2/3clocksource/drivers/mips-gic-timer: Replace setup_percpu_irq() by request_percpu_irq() variantdrivers/clocksource/mips-gic-timer.c+2 -80 replies
3/3genirq: Remove setup_percpu_irq() and remove_percpu_irq()include/linux/irq.h kernel/irq/manage.c+0 -440 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Remove setup_percpu_irq() & remove_percpu_irq

Hi,

While doing the removal of setup_irq(), it was observed that setup_percpu_irq() also can be removed similarly by replacing it w/ request_percpu_irq(), which does allocate memory. In the initial setup_irq() removal cover letters [1], it was mentioned that setup_percpu_irq() is untouched.

After removing setup_irq(), it does not look good to let live setup_percpu_irq(), especially since it being a low hanging fruit. Hence replace setup_percpu_irq() by it's allocator equivalent. request_percpu_irq() cannot be used since all the users need to pass IRQF_TIMER flag, which it would not allow. Thus it's variant, __request_percpu_irq() is used.

In addition to removing setup_percpu_irq() definition, remove_percpu_irq(), unused, is also removed.

It seems setup_percpu_irq() is used only by MIPS (even the one outside MIPS arch dir, i.e. the clocksource driver). The series has been build tested, though i would have loved to do a qemu test as well, i do not see a qemu machine type that can test the changes done here (in malta machine, in which clocksource changes are getting built, the changes done here are not being runtime tested).

Regards
afzal

[1] https://lkml.kernel.org/r/[email protected]

afzal mohammed (3):
MIPS: Replace setup_percpu_irq() by request_percpu_irq() variant clocksource/drivers/mips-gic-timer: Replace setup_percpu_irq() by
request_percpu_irq() variant
genirq: Remove setup_percpu_irq() and remove_percpu_irq()

 arch/mips/include/asm/cevt-r4k.h     |  1 -
 arch/mips/kernel/cevt-r4k.c          | 11 --------
 arch/mips/sgi-ip27/ip27-timer.c      | 13 ++++-----
 arch/mips/sgi-ip30/ip30-timer.c      |  6 ++--
 drivers/clocksource/mips-gic-timer.c | 10 ++-----
 include/linux/irq.h                  |  2 --
 kernel/irq/manage.c                  | 42 ----------------------------
 7 files changed, 10 insertions(+), 75 deletions(-)
Signature · 1 line
2.18.0