bonding: fix port id check and PCI addr cmp
Status from this message: Applied to dpdk-next-net/main, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | bonding: fix port id validity check on parsingdrivers/ | +2 | 2 replies | |
| 2/2 | bonding: fix PCI address comparison on non-pci portsdrivers/ | +25 | 4 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Min Hu (Connor) |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [dpdk-dev] [PATCH v1 0/2] bonding: fix port id check and PCI addr cmp
Found these two bugs while reading the bonding code.
The first bug is mostly usability: if a user gives an incorrect port id as a slave, it will error-out later. The error will simply be less clear.
I'm partially responsible for the second one. I don't see why we did not wrote it properly at the time: the comment about lacking the proper rte_bus_pci impl was already not correct anymore when the check on the kdrv was removed. The necessary functions were already available I think.
Gaetan Rivet (2):
bonding: fix port id validity check on parsing
bonding: fix PCI address comparison on non-pci ports
drivers/net/bonding/rte_eth_bond_args.c | 63 +++++++++++-------------- 1 file changed, 27 insertions(+), 36 deletions(-)
Signature · 1 line
2.26.0