Skip to content

t: replace incorrect test_must_fail usage (part 4)

Denton Liu git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8t6030: use test_path_is_missing()t/t6030-bisect-porcelain.sh+4 -40 replies
2/8t7408: replace incorrect uses of test_must_failt/t7408-submodule-reference.sh+4 -40 replies
3/8t7508: don't use `test_must_fail test_cmp`t/t7508-status.sh+1 -11 reply
4/8t9141: use test_path_is_missing()t/t9141-git-svn-multiple-branches.sh+4 -40 replies
5/8t9160: use test_path_is_missing()t/t9160-git-svn-preserve-empty-dirs.sh+2 -20 replies
6/8t9164: don't use `test_must_fail test_cmp`t/t9164-git-svn-dcommit-concurrent.sh+2 -27 replies
7/8t9819: don't use test_must_fail with p4t/t9819-git-p4-case-folding.sh+1 -10 replies
8/8t9902: don't use `test_must_fail __git_*`t/t9902-completion.sh+6 -62 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] t: replace incorrect test_must_fail usage (part 4)

The overall scope of these patches is to replace inappropriate uses of test_must_fail. IOW, we should only allow test_must_fail to run on git and test-tool. Ultimately, we will conclude by making test_must_fail error out on non-git commands. An advance view of the final series can be found here[1].

This is the fourth part. It focuses on t[6-9]*.sh.

The first part can be found here[2]. The second part can be found here[3]. The third part can be found here[4].

[1]: (may be rebased at any time) https://github.com/Denton-L/git/tree/ready/cleanup-test-must-fail2
[2]: https://lore.kernel.org/git/[email protected]/
[3]: https://lore.kernel.org/git/[email protected]/
[4]: https://lore.kernel.org/git/[email protected]/

Denton Liu (8):
t6030: use test_path_is_missing()
t7408: replace incorrect uses of test_must_fail
t7508: don't use test_must_fail test_cmp
t9141: use test_path_is_missing()
t9160: use test_path_is_missing()
t9164: don't use test_must_fail test_cmp
t9819: don't use test_must_fail with p4
t9902: don't use test_must_fail __git_*

 t/t6030-bisect-porcelain.sh            |  8 ++++----
 t/t7408-submodule-reference.sh         |  8 ++++----
 t/t7508-status.sh                      |  2 +-
 t/t9141-git-svn-multiple-branches.sh   |  8 ++++----
 t/t9160-git-svn-preserve-empty-dirs.sh |  4 ++--
 t/t9164-git-svn-dcommit-concurrent.sh  |  4 ++--
 t/t9819-git-p4-case-folding.sh         |  2 +-
 t/t9902-completion.sh                  | 12 ++++++------
 8 files changed, 24 insertions(+), 24 deletions(-)
Signature · 1 line
2.26.0.159.g23e2136ad0