Skip to content

pack-bitmap: use bitmaps for traversals with '--filter=tree:0'

Taylor Blau git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4list-objects-filter: treat NULL filter_options as "disabled"list-objects-filter.c+3 -00 replies
2/4pack-bitmap.c: make object filtering functions genericpack-bitmap.c+24 -110 replies
3/4pack-bitmap.c: support 'tree:0' filteringpack-bitmap.c t/perf/p5310-pack-bitmaps.sh t/t6113-rev-list-bitmap-filters.sh+50 -10 replies
4/4pack-bitmap: pass object filter to fill-in traversalpack-bitmap.c t/perf/p5310-pack-bitmaps.sh+14 -52 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] pack-bitmap: use bitmaps for traversals with '--filter=tree:0'

Hi,

This series contains a handful of patches to make object traversals with '--filter=tree:0' be bitmaps-compatible. They have been kicking around in GitHub's fork for some time, and we use them on every '--filter=tree:0' fetch.

This is a prerequisite for a future series which will introduce configuration in upload-pack to indicate which filter choices are and aren't supported [1]. Since sending [1], GitHub's fork has grown support for

[uploadpack 'filter.tree']
maxDepth = <n>

...and so I figure that we could get this smaller series out for discussion before introducing that option, which doesn't make sense without having some faster variant of the 'tree' filter for certain values of 'n'.

Thanks,
Taylor

[1]: https://lore.kernel.org/git/[email protected]/

Jeff King (2):
list-objects-filter: treat NULL filter_options as "disabled"
pack-bitmap: pass object filter to fill-in traversal

Taylor Blau (2):
pack-bitmap.c: make object filtering functions generic pack-bitmap.c: support 'tree:0' filtering

 list-objects-filter.c              |  3 ++
 pack-bitmap.c                      | 72 +++++++++++++++++++++++-------
 t/perf/p5310-pack-bitmaps.sh       | 10 +++++
 t/t6113-rev-list-bitmap-filters.sh | 21 +++++++++
 4 files changed, 90 insertions(+), 16 deletions(-)

--
2.26.2.112.g65467a058e