Skip to content

build golang tools

Nick Rosbrook xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Change make variable to CONFIG_GOLANG, and use golang rather than golang_tools to avoid mixing underscores and hyphens in configure flags.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tools: build golang tools if go compiler is presentconfig/Tools.mk.in m4/golang.m4 tools/Rules.mk +2 more+155 -21 reply
2/2golang/xenlight: stop tracking generated files.gitignore .hgignore tools/golang/xenlight/Makefile +2 more+6 -59470 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchWei LiuGeorge Dunlap
1/2A-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] build golang tools

These patches add support for the golang tools in the build system.

The behavior of configure with respect to the make variable, CONFIG_GOLANG is copied from other components, such as the Ocaml tools. Namely, build the tools by default if the go compiler is found.

Changes in v2:
- Change make variable to CONFIG_GOLANG, and use golang rather than golang_tools to avoid mixing underscores and hyphens in configure flags.

Nick Rosbrook (2):
tools: build golang tools if go compiler is present golang/xenlight: stop tracking generated files

 .gitignore                           |    3 +
 .hgignore                            |    2 +
 config/Tools.mk.in                   |    1 +
 m4/golang.m4                         |    4 +
 tools/Rules.mk                       |    2 -
 tools/configure                      |  138 +
 tools/configure.ac                   |   12 +
 tools/golang/xenlight/Makefile       |    1 +
 tools/golang/xenlight/helpers.gen.go | 4722 --------------------------
 tools/golang/xenlight/types.gen.go   | 1225 -------
 10 files changed, 161 insertions(+), 5949 deletions(-)
 create mode 100644 m4/golang.m4
 delete mode 100644 tools/golang/xenlight/helpers.gen.go
 delete mode 100644 tools/golang/xenlight/types.gen.go
Signature · 1 line
2.17.1