Skip to content

shallow.c: reset shallow-ness after updating

Taylor Blau git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 18 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2t5537: use test_write_lines, indented heredocs for readabilityt/t5537-fetch-shallow.sh+18 -524 replies
2/2shallow.c: use '{commit,rollback}_shallow_file'builtin/receive-pack.c commit.h fetch-pack.c +2 more+59 -1614 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJonathan TanJunio C HamanoJonathan Nieder
1/2R-b
2/2Helped-by R-b Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] shallow.c: reset shallow-ness after updating

Hi,

Here is an updated version of the patch that I sent above (which was itself an updated version of a patch that I sent to some other sub-thread...).

In this version, I added an extra patch at the beginning to clean up some surrounding tests in t5537 so the new ones are added both in a good style, and in a way that is consistent with the surrounding code.

I also adopted a suggestion from Junio that introduces '{commit,rollback}_shallow_file()' as thin wrappers around '{commit,rollback}_lock_file()', which makes this whole thing a lot tidier.

Thanks in advance for another look...

Taylor Blau (2):
t5537: use test_write_lines, indented heredocs for readability shallow.c: use '{commit,rollback}_shallow_file'

 builtin/receive-pack.c   |  4 +-
 commit.h                 |  2 +
 fetch-pack.c             | 10 ++--
 shallow.c                | 30 ++++++++----
 t/t5537-fetch-shallow.sh | 99 +++++++++++++++++++---------------------
 5 files changed, 77 insertions(+), 68 deletions(-)

--
2.26.0.113.ge9739cdccc