Skip to content

Partial fix `make sparse`

Đoàn Trần Công Danh git linux-sparse 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesIn review
  2. v24 patches 15 repliesSuperseded
  3. v14 patches 18 repliesSuperseded

Change in v3 from v2 from the cover letter

* rewrite [2/4] based on Ramsay's suggestion

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4test-parse-pathspec-file.c: s/0/NULL/ for pointer typet/helper/test-parse-pathspec-file.c+3 -30 replies
2/4compat/regex: move stdlib.h up in inclusion chaincompat/regex/regex.c compat/regex/regex_internal.h+1 -11 reply
3/4graph.c: limit linkage of internal variablegraph.c+1 -10 replies
4/4progress.c: silence cgcc suggestion about internal linkageprogress.c progress.h t/helper/test-progress.c+10 -91 reply

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchRamsay Jones
1/4
2/4Helped-by
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Partial fix `make sparse`

Change in v3 from v2:
* rewrite [2/4] based on Ramsay's suggestion

Change in v2 from v1:
* = { 0 } is an idiom to zero the structure, it shouldn't be changed
* change in [4/4] for prototype
* ignore diffent function prototype

Đoàn Trần Công Danh (4):
test-parse-pathspec-file.c: s/0/NULL/ for pointer type compat/regex: move stdlib.h up in inclusion chain graph.c: limit linkage of internal variable progress.c: silence cgcc suggestion about internal linkage

 compat/regex/regex.c                | 1 +
 compat/regex/regex_internal.h       | 1 -
 graph.c                             | 2 +-
 progress.c                          | 2 +-
 progress.h                          | 8 ++++++++
 t/helper/test-parse-pathspec-file.c | 6 +++---
 t/helper/test-progress.c            | 9 +--------
 7 files changed, 15 insertions(+), 14 deletions(-)

Range-diff against v2:

1:  c9a1812abf = 1:  c9a1812abf test-parse-pathspec-file.c: s/0/NULL/ for pointer type
2:  290ba923b5 < -:  ---------- compat/regex: include alloca.h before undef it
-:  ---------- > 2:  8d18c53bc8 compat/regex: move stdlib.h up in inclusion chain
3:  39f8d85c2f = 3:  4e7580e1d1 graph.c: limit linkage of internal variable
4:  41eecf18ed = 4:  d66d9aa677 progress.c: silence cgcc suggestion about internal linkage
Signature · 1 line
2.26.2.526.g744177e7f7