RFC mptcp: more incoming option fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mptcp: add and use wrappers to manipulate mptcp opt flagsinclude/ net/ net/ +2 more | +101 | 0 replies | |
| 2/5 | mptcp: use a single sub_option field in mptcp_incoming_optioninclude/ net/ net/ | +17 | 0 replies | |
| 3/5 | tcp: init MPTCP option before parsing.include/ net/ net/ | +1 | 1 reply | |
| 4/5 | mptcp: avoid a WARN on bad input.net/ | +2 | 0 replies | |
| 5/5 | mptcp: fix 'use_ack' option access.net/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [MPTCP] [RFC PATCH 0/5] mptcp: more incoming option fixes
This is a very early RFC showcasing the fix discussed in yday mtg - the first 3 patches. It contains also fix/warkaround for the last warn() I'm able to hit with syzbot repro provided by Christoph.
With this series and https://marc.info/?l=linux-netdev&m=158772695009150&w=2
on top of -net I haven't hit any of the 'known' oops/warn so far, but I'm hitting a WARN_ONCE("Bad mapping: "...) I'm unsure it's introduced here or not.
Paolo Abeni (5):
mptcp: add and use wrappers to manipulate mptcp opt flags
mptcp: use a single sub_option field in mptcp_incoming_option
tcp: init MPTCP option before parsing.
mptcp: avoid a WARN on bad input.
mptcp: fix 'use_ack' option access.
include/linux/tcp.h | 27 +++++++++----------- net/ipv4/tcp_input.c | 1 + net/mptcp/options.c | 41 +++++++++++++++--------------- net/mptcp/protocol.c | 2 +- net/mptcp/protocol.h | 60 ++++++++++++++++++++++++++++++++++++++++++++ net/mptcp/subflow.c | 23 ++++++++--------- 6 files changed, 105 insertions(+), 49 deletions(-)
Signature · 1 line
2.21.1