Skip to content

Protocol v2 in_vain fixes

Jonathan Tan git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v12 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fetch-pack: return enum from process_acks()fetch-pack.c+28 -74 replies
2/3fetch-pack: in protocol v2, in_vain only after ACKfetch-pack.c t/t5500-fetch-pack.sh+27 -47 replies
3/3fetch-pack: in protocol v2, reset in_vain upon ACKfetch-pack.c t/t5500-fetch-pack.sh+31 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJonathan Nieder
1/3R-b
2/3R-b
3/3Helped-by R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Protocol v2 in_vain fixes

I'm not sure if Jonathan Nieder meant the enum-from-process_acks() change should be in this patch set, but I've included it here anyway. Also I've removed an extraneous debug "cp" from patch 2/3 (previously patch 1/2).

Jonathan Tan (3):
fetch-pack: return enum from process_acks()
fetch-pack: in protocol v2, in_vain only after ACK
fetch-pack: in protocol v2, reset in_vain upon ACK

 fetch-pack.c          | 49 +++++++++++++++++++++++++++++++++----------
 t/t5500-fetch-pack.sh | 48 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 86 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog