Skip to content

staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c

Rylan Dmello lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 4 repliesIn review

Changes in v2 from the cover letter

- Addressed feedback from Joe Perches by unindenting ql_set_mac_addr_reg and by replacing goto statements with break statements in the function.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7staging: qlge: Fix indentation in ql_set_mac_addr_regdrivers/staging/qlge/qlge_main.c+78 -890 replies
2/7staging: qlge: Remove gotos from ql_set_mac_addr_regdrivers/staging/qlge/qlge_main.c+6 -93 replies
3/7staging: qlge: Fix indentation in ql_get_mac_addr_regdrivers/staging/qlge/qlge_main.c+37 -390 replies
4/7staging: qlge: Remove goto statements from ql_get_mac_addr_regdrivers/staging/qlge/qlge_main.c+6 -70 replies
5/7staging: qlge: Remove multi-line dereference from ql_request_irqdrivers/staging/qlge/qlge_main.c+3 -30 replies
6/7staging: qlge: Fix suspect code indent warning in ql_init_devicedrivers/staging/qlge/qlge_main.c+2 -10 replies
7/7staging: qlge: Fix function argument alignment warning in ql_init_devicedrivers/staging/qlge/qlge_main.c+2 -40 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchDan Carpenter
1/7
2/7R-b
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c

This patchset fixes some indentation- and style-related issues in qlge_main.c reported by checkpatch.pl, such as:

WARNING: Avoid multiple line dereference
WARNING: line over 80 characters
WARNING: suspect code indent for conditional statements

v2:
- Addressed feedback from Joe Perches by unindenting ql_set_mac_addr_reg and by replacing goto statements with break statements in the function.

Rylan Dmello (7):
staging: qlge: Fix indentation in ql_set_mac_addr_reg
staging: qlge: Remove gotos from ql_set_mac_addr_reg
staging: qlge: Fix indentation in ql_get_mac_addr_reg
staging: qlge: Remove goto statements from ql_get_mac_addr_reg
staging: qlge: Remove multi-line dereference from ql_request_irq
staging: qlge: Fix suspect code indent warning in ql_init_device
staging: qlge: Fix function argument alignment warning in
ql_init_device

 drivers/staging/qlge/qlge_main.c | 258 ++++++++++++++-----------------
 1 file changed, 120 insertions(+), 138 deletions(-)
Signature · 1 line
2.26.2