staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest7 patches 4 repliesIn review
Changes in v2 from the cover letter
- Addressed feedback from Joe Perches by unindenting ql_set_mac_addr_reg and by replacing goto statements with break statements in the function.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | staging: qlge: Fix indentation in ql_set_mac_addr_regdrivers/ | +78 | 0 replies | |
| 2/7 | staging: qlge: Remove gotos from ql_set_mac_addr_regdrivers/ | +6 | 3 replies | |
| 3/7 | staging: qlge: Fix indentation in ql_get_mac_addr_regdrivers/ | +37 | 0 replies | |
| 4/7 | staging: qlge: Remove goto statements from ql_get_mac_addr_regdrivers/ | +6 | 0 replies | |
| 5/7 | staging: qlge: Remove multi-line dereference from ql_request_irqdrivers/ | +3 | 0 replies | |
| 6/7 | staging: qlge: Fix suspect code indent warning in ql_init_devicedrivers/ | +2 | 0 replies | |
| 7/7 | staging: qlge: Fix function argument alignment warning in ql_init_devicedrivers/ | +2 | 0 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by.
| Patch | Dan Carpenter |
|---|---|
| 1/7 | |
| 2/7 | R-b |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c
This patchset fixes some indentation- and style-related issues in qlge_main.c reported by checkpatch.pl, such as:
WARNING: Avoid multiple line dereference
WARNING: line over 80 characters
WARNING: suspect code indent for conditional statements
v2:
- Addressed feedback from Joe Perches by unindenting ql_set_mac_addr_reg and by replacing goto statements with break statements in the function.
Rylan Dmello (7):
staging: qlge: Fix indentation in ql_set_mac_addr_reg
staging: qlge: Remove gotos from ql_set_mac_addr_reg
staging: qlge: Fix indentation in ql_get_mac_addr_reg
staging: qlge: Remove goto statements from ql_get_mac_addr_reg
staging: qlge: Remove multi-line dereference from ql_request_irq
staging: qlge: Fix suspect code indent warning in ql_init_device
staging: qlge: Fix function argument alignment warning in
ql_init_device
drivers/staging/qlge/qlge_main.c | 258 ++++++++++++++----------------- 1 file changed, 120 insertions(+), 138 deletions(-)
Signature · 1 line
2.26.2