Skip to content

rs485 bus termination GPIO

Lukas Wunner linux-devicetree linux-serial 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v24 patches 3 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Changes in v3 from the cover letter

* Patch [2/2]:
* Drop unnecessary NULL pointer check preceding gpiod_set_value(). (Heiko)
* Amend commit message to suggest moving 8250_exar.c to new binding. (Andy) Add Jan to Cc and Andy's R-b tag.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: serial: Add binding for rs485 bus termination GPIODocumentation/devicetree/bindings/serial/rs485.yaml+4 -01 reply
2/2serial: 8250: Support rs485 bus termination GPIOdrivers/tty/serial/8250/8250_port.c drivers/tty/serial/serial_core.c include/linux/serial_core.h+21 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoRob Herring
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] rs485 bus termination GPIO

Define a device tree binding for an rs485 bus termination GPIO (patch [1/2]), amend the serial core to retrieve the GPIO from the device tree and amend the default ->rs485_config() callback for 8250 drivers to change the GPIO on request from user space (patch [2/2]).

Changes v2 -> v3:

* Patch [2/2]:
* Drop unnecessary NULL pointer check preceding gpiod_set_value(). (Heiko)
* Amend commit message to suggest moving 8250_exar.c to new binding. (Andy) Add Jan to Cc and Andy's R-b tag.

Changes v1 -> v2:

* Patch [2/2]:
* Drop unnecessary devm_gpiod_put(). (Andy)
* Use GPIOD_OUT_LOW macro for brevity. (Andy)
* Document the rationale for disabling termination by default.
* Drop nonsensical read of GPIO after setting its direction to out.

Link to v2:
https://lore.kernel.org/linux-serial/[email protected]

Lukas Wunner (2):
dt-bindings: serial: Add binding for rs485 bus termination GPIO
serial: 8250: Support rs485 bus termination GPIO

 .../devicetree/bindings/serial/rs485.yaml        |  4 ++++
 drivers/tty/serial/8250/8250_port.c              |  3 +++
 drivers/tty/serial/serial_core.c                 | 16 ++++++++++++++++
 include/linux/serial_core.h                      |  2 ++
 4 files changed, 25 insertions(+)
Signature · 1 line
2.26.2