Skip to content

net: qed/qede: critical hw error handling

Igor Russkikh netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 7 repliesIn review
  2. v112 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11net: qed: adding hw_err states and handlingdrivers/net/ethernet/qlogic/qed/qed.h drivers/net/ethernet/qlogic/qed/qed_hw.c drivers/net/ethernet/qlogic/qed/qed_hw.h +2 more+90 -00 replies
2/11net: qede: add hw err scheduled handlerdrivers/net/ethernet/qlogic/qede/qede.h drivers/net/ethernet/qlogic/qede/qede_main.c+106 -20 replies
3/11net: qed: invoke err notify on critical areasdrivers/net/ethernet/qlogic/qed/qed_dev.c drivers/net/ethernet/qlogic/qed/qed_hw.c drivers/net/ethernet/qlogic/qed/qed_int.c +2 more+35 -140 replies
4/11net: qed: critical err reporting to management firmwaredrivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_hw.c drivers/net/ethernet/qlogic/qed/qed_mcp.c +1 more+162 -00 replies
5/11net: qed: cleanup debug related declarationsdrivers/net/ethernet/qlogic/qed/qed.h drivers/net/ethernet/qlogic/qed/qed_debug.c+16 -210 replies
6/11net: qed: attention clearing propertiesdrivers/net/ethernet/qlogic/qed/qed.h drivers/net/ethernet/qlogic/qed/qed_int.c drivers/net/ethernet/qlogic/qed/qed_int.h +3 more+53 -50 replies
7/11net: qede: optional hw recovery proceduredrivers/net/ethernet/qlogic/qede/qede_ethtool.c+24 -00 replies
8/11net: qede: Implement ndo_tx_timeoutdrivers/net/ethernet/qlogic/qede/qede.h drivers/net/ethernet/qlogic/qede/qede_main.c+46 -10 replies
9/11net: qed: introduce critical fan failure handlerdrivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_mcp.c+15 -10 replies
10/11net: qed: introduce critical hardware error handlerdrivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_mcp.c drivers/net/ethernet/qlogic/qed/qed_mcp.h+153 -10 replies
11/11net: qed: fix bad formattinginclude/linux/qed/qed_if.h+2 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

FastLinQ devices as a complex systems may observe various hardware level error conditions, both severe and recoverable.

Driver is able to detect and report this, but so far it only did trace/dmesg based reporting.

Here we implement an extended hw error detection, service task handler captures a dump for the later analysis.

I also resubmit a patch from Denis Bolotin on tx timeout handler, addressing David's comment regarding recovery procedure as an extra reaction on this event.

v2:

Removing the patch with ethtool dump and udev magic. Its quite isolated, I'm working on devlink based logic for this separately.

v1:

https://patchwork.ozlabs.org/project/netdev/cover/[email protected]/

Denis Bolotin (1):
net: qede: Implement ndo_tx_timeout

Igor Russkikh (10):
net: qed: adding hw_err states and handling
net: qede: add hw err scheduled handler
net: qed: invoke err notify on critical areas
net: qed: critical err reporting to management firmware
net: qed: cleanup debug related declarations
net: qed: attention clearing properties
net: qede: optional hw recovery procedure
net: qed: introduce critical fan failure handler
net: qed: introduce critical hardware error handler
net: qed: fix bad formatting

 drivers/net/ethernet/qlogic/qed/qed.h         |  16 +-
 drivers/net/ethernet/qlogic/qed/qed_debug.c   |  26 +-
 drivers/net/ethernet/qlogic/qed/qed_dev.c     |   4 +-
 drivers/net/ethernet/qlogic/qed/qed_hsi.h     |  49 +++-
 drivers/net/ethernet/qlogic/qed/qed_hw.c      |  42 ++-
 drivers/net/ethernet/qlogic/qed/qed_hw.h      |  15 ++
 drivers/net/ethernet/qlogic/qed/qed_int.c     |  40 ++-
 drivers/net/ethernet/qlogic/qed/qed_int.h     |  11 +
 drivers/net/ethernet/qlogic/qed/qed_main.c    |  34 +++
 drivers/net/ethernet/qlogic/qed/qed_mcp.c     | 254 ++++++++++++++++++
 drivers/net/ethernet/qlogic/qed/qed_mcp.h     |  28 ++
 drivers/net/ethernet/qlogic/qed/qed_spq.c     |  16 +-
 drivers/net/ethernet/qlogic/qede/qede.h       |  14 +-
 .../net/ethernet/qlogic/qede/qede_ethtool.c   |  24 ++
 drivers/net/ethernet/qlogic/qede/qede_main.c  | 147 +++++++++-
 include/linux/qed/qed_if.h                    |  26 +-
 16 files changed, 700 insertions(+), 46 deletions(-)
Signature · 1 line
2.17.1