Skip to content

RFC ext4: mballoc/extents: Code cleanup and debug improvements

Ritesh Harjani linux-ext4 linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest16 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16ext4: mballoc: Do print bb_free info even when it is 0fs/ext4/mballoc.c+0 -20 replies
2/16ext4: mballoc: Refactor ext4_mb_show_ac()fs/ext4/mballoc.c+40 -250 replies
3/16ext4: mballoc: Add more mb_debug() msgsfs/ext4/mballoc.c+14 -40 replies
4/16ext4: mballoc: Correct the mb_debug() format specifier for pa_len varfs/ext4/mballoc.c+5 -50 replies
5/16ext4: mballoc: Fix few other format specifier in mb_debug()fs/ext4/mballoc.c+6 -60 replies
6/16ext4: mballoc: Simplify error handling in ext4_init_mballoc()fs/ext4/mballoc.c+13 -100 replies
7/16ext4: mballoc: Make ext4_mb_use_preallocated() return type as boolfs/ext4/mballoc.c+7 -70 replies
8/16ext4: mballoc: Refactor code inside DOUBLE_CHECK into separate functionfs/ext4/mballoc.c+33 -170 replies
9/16ext4: mballoc: Fix possible NULL ptr & remove BUG_ONs from DOUBLE_CHECKfs/ext4/mballoc.c+9 -20 replies
10/16ext4: balloc: Use task_pid_nr() helperfs/ext4/balloc.c+3 -20 replies
11/16ext4: Use BIT() macro for BH_** state bitsfs/ext4/ext4.h fs/ext4/inode.c+6 -60 replies
12/16ext4: Improve ext_debug() msg in case of block allocation failurefs/ext4/extents.c fs/ext4/inode.c+6 -20 replies
13/16ext4: Replace EXT_DEBUG with __maybe_unused in ext4_ext_handle_unwritten_extents()fs/ext4/extents.c+1 -30 replies
14/16ext4: mballoc: Make mb_debug() implementation to use pr_debug()fs/ext4/Kconfig fs/ext4/mballoc.c fs/ext4/mballoc.h+55 -680 replies
15/16ext4: Make ext_debug() implementation to use pr_debug()fs/ext4/Kconfig fs/ext4/ext4.h fs/ext4/extents.c +1 more+87 -880 replies
16/16ext4: Add process name and pid in ext4_msg()fs/ext4/super.c+2 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/16] ext4: mballoc/extents: Code cleanup and debug improvements

Hello All,

This series does some code refactoring/cleanups and debug logs improvements around mb_debug() and ext_debug(). These were found when working over improving mballoc ENOSPC handling in ext4.
These should be small and stright forward patches for reviewing.

Ritesh Harjani (16):
ext4: mballoc: Do print bb_free info even when it is 0
ext4: mballoc: Refactor ext4_mb_show_ac()
ext4: mballoc: Add more mb_debug() msgs
ext4: mballoc: Correct the mb_debug() format specifier for pa_len var
ext4: mballoc: Fix few other format specifier in mb_debug()
ext4: mballoc: Simplify error handling in ext4_init_mballoc()
ext4: mballoc: Make ext4_mb_use_preallocated() return type as bool
ext4: mballoc: Refactor code inside DOUBLE_CHECK into separate function
ext4: mballoc: Fix possible NULL ptr & remove BUG_ONs from DOUBLE_CHECK
ext4: balloc: Use task_pid_nr() helper
ext4: Use BIT() macro for BH_** state bits
ext4: Improve ext_debug() msg in case of block allocation failure
ext4: Replace EXT_DEBUG with __maybe_unused in ext4_ext_handle_unwritten_extents()
ext4: mballoc: Make mb_debug() implementation to use pr_debug()
ext4: Make ext_debug() implementation to use pr_debug()
ext4: Add process name and pid in ext4_msg()

 fs/ext4/Kconfig   |   3 +-
 fs/ext4/balloc.c  |   5 +-
 fs/ext4/ext4.h    |  26 +++--
 fs/ext4/extents.c | 150 +++++++++++++-------------
 fs/ext4/inode.c   |  15 +--
 fs/ext4/mballoc.c | 265 ++++++++++++++++++++++++++--------------------
 fs/ext4/mballoc.h |  16 ++-
 fs/ext4/super.c   |   3 +-
 8 files changed, 261 insertions(+), 222 deletions(-)
Signature · 1 line
2.21.0