Skip to content

bpf: sk lookup, cgroup id helpers in cgroup skb

Andrey Ignatov bpf 3 versions – Applied

Status from this message: Applied. Thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 2 repliesApplied
  2. v25 patches 11 repliesSuperseded
  3. v15 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- better documentation for bpf_sk_cgroup_id in uapi (Yonghong Song)
- save/restore errno in network helpers (Yonghong Song)
- cleanup leftover after switching selftest to skeleton (Yonghong Song)
- switch from map to skel->bss in selftest (Yonghong Song)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5bpf: Allow sk lookup helpers in cgroup skbnet/core/filter.c+8 -00 replies
2/5bpf: Allow skb_ancestor_cgroup_id helper in cgroup skbnet/core/filter.c+2 -00 replies
3/5bpf: Introduce bpf_sk_{,ancestor_}cgroup_id helpersinclude/uapi/linux/bpf.h net/core/filter.c tools/include/uapi/linux/bpf.h+121 -110 replies
4/5selftests/bpf: Add connect_fd_to_fd, connect_wait net helperstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+63 -130 replies
5/5selftests/bpf: Test for sk helpers in cgroup skbtools/testing/selftests/bpf/prog_tests/cgroup_skb_sk_lookup.c tools/testing/selftests/bpf/progs/cgroup_skb_sk_lookup_kern.c+192 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchYonghong Song
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 bpf-next 0/5] bpf: sk lookup, cgroup id helpers in cgroup skb

v2->v3:
- better documentation for bpf_sk_cgroup_id in uapi (Yonghong Song)
- save/restore errno in network helpers (Yonghong Song)
- cleanup leftover after switching selftest to skeleton (Yonghong Song)
- switch from map to skel->bss in selftest (Yonghong Song)

v1->v2:
- switch selftests to skeleton.

This patch set allows a bunch of existing sk lookup and skb cgroup id helpers, and adds two new bpf_sk_{,ancestor_}cgroup_id helpers to be used in cgroup skb programs.

It fills the gap to cover a use-case to apply intra-host cgroup-bpf network policy based on a source cgroup a packet comes from.

For example, there can be multiple containers A, B, C running on a host. Every such container runs in its own cgroup that can have multiple sub-cgroups. But all these containers can share some IP addresses.

At the same time container A wants to have a policy for a server S running in it so that only clients from this same container can connect to S, but not from other containers (such as B, C). Source IP address can't be used to decide whether to allow or deny a packet, but it looks reasonable to filter by cgroup id.

The patch set allows to implement the following policy:
* when an ingress packet comes to container's cgroup, lookup peer (client) socket this packet comes from;
* having peer socket, get its cgroup id;
* compare peer cgroup id with self cgroup id and allow packet only if they match, i.e. it comes from same cgroup;
* the "sub-cgroup" part of the story can be addressed by getting not direct cgroup id of the peer socket, but ancestor cgroup id on specified level, similar to existing "ancestor" flavors of cgroup id helpers.

A newly introduced selftest implements such a policy in its basic form to provide a better idea on the use-case.

Patch 1 allows existing sk lookup helpers in cgroup skb. Patch 2 allows skb_ancestor_cgroup_id in cgrou skb. Patch 3 introduces two new helpers to get cgroup id of socket. Patch 4 extends network helpers to use them in the next patch. Patch 5 adds selftest / example of use-case.

Andrey Ignatov (5):
bpf: Allow sk lookup helpers in cgroup skb
bpf: Allow skb_ancestor_cgroup_id helper in cgroup skb
bpf: Introduce bpf_sk_{,ancestor_}cgroup_id helpers selftests/bpf: Add connect_fd_to_fd, connect_wait net helpers selftests/bpf: Test for sk helpers in cgroup skb

 include/uapi/linux/bpf.h                      | 36 ++++++-
 net/core/filter.c                             | 70 +++++++++++--
 tools/include/uapi/linux/bpf.h                | 36 ++++++-
 tools/testing/selftests/bpf/network_helpers.c | 74 +++++++++++---
 tools/testing/selftests/bpf/network_helpers.h |  2 +
 .../bpf/prog_tests/cgroup_skb_sk_lookup.c     | 95 ++++++++++++++++++
 .../bpf/progs/cgroup_skb_sk_lookup_kern.c     | 97 +++++++++++++++++++
 7 files changed, 386 insertions(+), 24 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/cgroup_skb_sk_lookup.c
 create mode 100644 tools/testing/selftests/bpf/progs/cgroup_skb_sk_lookup_kern.c
Signature · 1 line
2.24.1