Skip to content

Enable Greybus Audio codec driver

Vaibhav Agarwal lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 2 repliesIn review
  2. v36 patches 2 repliesSuperseded
  3. v26 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v1 posting 2/26 patches7 repliesSuperseded
v1 posting 1/26 patches2 repliesSuperseded

v1 from the cover letter

- Include the changes for the review comments suggested by Dan
- Rebase to latest staging-next

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7staging: greybus: audio: Update snd_jack FW usage as per new APIsdrivers/staging/greybus/audio_codec.c+42 -122 replies
2/7staging: greybus: audio: Maintain jack list within GB Audio moduledrivers/staging/greybus/audio_codec.c drivers/staging/greybus/audio_codec.h drivers/staging/greybus/audio_module.c+53 -460 replies
3/7staging: greybus: audio: Resolve compilation errors for GB codec moduledrivers/staging/greybus/audio_codec.c drivers/staging/greybus/audio_codec.h+44 -460 replies
4/7staging: greybus: audio: Resolve compilation error in topology parserdrivers/staging/greybus/audio_topology.c+57 -660 replies
5/7staging: greybus: audio: Add helper APIs for dynamic audio modulesdrivers/staging/greybus/Makefile drivers/staging/greybus/audio_codec.c drivers/staging/greybus/audio_helper.c +1 more+223 -50 replies
6/7staging: greybus: audio: Enable GB codec, audio module compilation.drivers/staging/greybus/Kconfig drivers/staging/greybus/Makefile+15 -30 replies
7/7drivers: staging: audio: Fix the missing header file for helper filedrivers/staging/greybus/audio_helper.c drivers/staging/greybus/audio_topology.c+5 -40 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchDan Carpenter
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] Enable Greybus Audio codec driver

The existing GB Audio codec driver is dependent on MSM8994 Audio driver. During the development stage, this dependency was configured due to various changes involved in MSM Audio driver to enable addtional codec card and some of the changes proposed in mainline ASoC framework. However, these are not the real dependencies and some of them can be easily removed.

The folowing patch series includes the changes to resolve unnecessary depedencies and make the codec driver functional with the latest kernel.

Patch 1,2: Incudes jack framework related changes.
Patch 3,4,5: Resolves compilation error observed with the latest kernel and also provides helper APIs required to allow dynamic addition/removal of modules.
Patch 6: Finally provides config options and related Makefile changes to enable GB Codec driver.

Thanks to Alexandre for raising the headsup [1] and motivating me to provide the necessary changes.

This patchset is intended to resolve the componentization issue only. And as per the suggestion [2] from Mark, I'll share a separate patch series aligned to ASoC tree. Once the relevant changes are accepted in snd-soc framework, I'll share relevant patches to pull GB Audio out of the staging tree.

v1:
- Include the changes for the review comments suggested by Dan
- Rebase to latest staging-next

v2:
- Avoid defining unused 'update' pointer
- Fix the missing connect bool value required during mixer_update_power
- Added Reviewed-by tag from Dan
- Rebase to latest staging-next

v3:
- Fix the warnings reported by lkp[3]
- Rebase to latest staging-next

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/alsa-devel/[email protected]/
[3] https://lore.kernel.org/lkml/202006200150.mNVj1Duq%[email protected]/

Vaibhav Agarwal (7):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio: Maintain jack list within GB Audio module
staging: greybus: audio: Resolve compilation errors for GB codec
module
staging: greybus: audio: Resolve compilation error in topology parser
staging: greybus: audio: Add helper APIs for dynamic audio modules
staging: greybus: audio: Enable GB codec, audio module compilation.
drivers: staging: audio: Fix the missing header file for helper file

 drivers/staging/greybus/Kconfig          |  14 +-
 drivers/staging/greybus/Makefile         |   6 +-
 drivers/staging/greybus/audio_codec.c    | 178 +++++++++++---------
 drivers/staging/greybus/audio_codec.h    |  12 +-
 drivers/staging/greybus/audio_helper.c   | 198 +++++++++++++++++++++++
 drivers/staging/greybus/audio_helper.h   |  17 ++
 drivers/staging/greybus/audio_module.c   |  15 +-
 drivers/staging/greybus/audio_topology.c | 131 +++++++--------
 8 files changed, 414 insertions(+), 157 deletions(-)
 create mode 100644 drivers/staging/greybus/audio_helper.c
 create mode 100644 drivers/staging/greybus/audio_helper.h

base-commit: 14442181d20490945f341644bb8257e334b01447

Signature · 1 line
2.27.0