Skip to content

Add get{peer,sock}name cgroup attach types

Daniel Borkmann bpf netdev 2 versions Applied

Status from this message: Applied. Thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyApplied
  2. v14 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- use __u16 for ports in start_server_with_port() signature and in expected_{local,peer} ports in the test case (Andrey)
- Added both Andrii's and Andrey's ACKs

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4bpf: add get{peer,sock}name attach types for sock_addrinclude/linux/bpf-cgroup.h include/uapi/linux/bpf.h kernel/bpf/syscall.c +5 more+42 -60 replies
2/4bpf, libbpf: enable get{peer,sock}name attach typestools/lib/bpf/libbpf.c+8 -00 replies
3/4bpf, bpftool: enable get{peer,sock}name attach typestools/bpf/bpftool/Documentation/bpftool-cgroup.rst tools/bpf/bpftool/Documentation/bpftool-prog.rst tools/bpf/bpftool/bash-completion/bpftool +3 more+30 -150 replies
4/4bpf, testing: add get{peer,sock}name selftests to test_progstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/connect_force_port.c +2 more+215 -330 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAndrii NakryikoAndrey Ignatov
1/4A-b A-b
2/4A-b A-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/4] Add get{peer,sock}name cgroup attach types

Trivial patch to add get{peer,sock}name cgroup attach types to the BPF sock_addr programs in order to enable rewriting sockaddr structs from both calls along with libbpf and bpftool support as well as selftests.

Thanks!

v1 -> v2:
- use __u16 for ports in start_server_with_port() signature and in expected_{local,peer} ports in the test case (Andrey)
- Added both Andrii's and Andrey's ACKs

Daniel Borkmann (4):
bpf: add get{peer,sock}name attach types for sock_addr bpf, libbpf: enable get{peer,sock}name attach types bpf, bpftool: enable get{peer,sock}name attach types bpf, testing: add get{peer,sock}name selftests to test_progs

 include/linux/bpf-cgroup.h                    |   1 +
 include/uapi/linux/bpf.h                      |   4 +
 kernel/bpf/syscall.c                          |  12 ++
 kernel/bpf/verifier.c                         |   6 +-
 net/core/filter.c                             |   4 +
 net/ipv4/af_inet.c                            |   8 +-
 net/ipv6/af_inet6.c                           |   9 +-
 .../bpftool/Documentation/bpftool-cgroup.rst  |  10 +-
 .../bpftool/Documentation/bpftool-prog.rst    |   3 +-
 tools/bpf/bpftool/bash-completion/bpftool     |  15 ++-
 tools/bpf/bpftool/cgroup.c                    |   7 +-
 tools/bpf/bpftool/main.h                      |   4 +
 tools/bpf/bpftool/prog.c                      |   6 +-
 tools/include/uapi/linux/bpf.h                |   4 +
 tools/lib/bpf/libbpf.c                        |   8 ++
 tools/testing/selftests/bpf/network_helpers.c |  11 +-
 tools/testing/selftests/bpf/network_helpers.h |   1 +
 .../bpf/prog_tests/connect_force_port.c       | 107 +++++++++++++-----
 .../selftests/bpf/progs/connect_force_port4.c |  59 +++++++++-
 .../selftests/bpf/progs/connect_force_port6.c |  70 +++++++++++-
 20 files changed, 295 insertions(+), 54 deletions(-)
Signature · 1 line
2.21.0