Skip to content

Misc display/sm501 clean ups and fixes

BALATON Zoltan qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 5 repliesIn review
  2. v16 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7sm501: Convert printf + abort to qemu_log_maskhw/display/sm501.c+27 -300 replies
2/7sm501: Shorten long variable names in sm501_2d_operationhw/display/sm501.c+22 -230 replies
3/7sm501: Use BIT(x) macro to shorten constanthw/display/sm501.c+2 -30 replies
4/7sm501: Clean up local variables in sm501_2d_operationhw/display/sm501.c+16 -150 replies
5/7sm501: Replace hand written implementation with pixman where possiblehw/display/sm501.c+119 -884 replies
6/7sm501: Optimize small overlapping blitshw/display/sm501.c+11 -40 replies
7/7sm501: Remove obsolete changelog and todo commenthw/display/sm501.c+1 -180 replies

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/7R-b
2/7
3/7R-b
4/7R-b
5/7
6/7
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] Misc display/sm501 clean ups and fixes

Second try of clean ups and changes to hopefully improve 2D engine performance and fix a security bug in it. This one actually works with AmigaOS handling overlapping blits, fixes the overflow checks and adds Reviewed-by tags. Unless some problems are found this should be OK to merge.

Regards,
BALATON Zoltan

BALATON Zoltan (7):
sm501: Convert printf + abort to qemu_log_mask
sm501: Shorten long variable names in sm501_2d_operation
sm501: Use BIT(x) macro to shorten constant
sm501: Clean up local variables in sm501_2d_operation
sm501: Replace hand written implementation with pixman where possible
sm501: Optimize small overlapping blits
sm501: Remove obsolete changelog and todo comment

 hw/display/sm501.c | 311 ++++++++++++++++++++++++---------------------
 1 file changed, 164 insertions(+), 147 deletions(-)
Signature · 1 line
2.21.3