Skip to content

mmc: zynqmp_sdhci: Add support for Tap delay

Michal Simek u-boot 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 0 repliesNew
  2. v28 patches 0 repliesSuperseded
  3. v17 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon
- replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Revert "mmc: zynq: parse dt when probing"drivers/mmc/sdhci.c drivers/mmc/zynq_sdhci.c include/sdhci.h+8 -10 replies
2/8mmc: Define timing macro'sboard/xilinx/zynqmp/tap_delays.c drivers/mmc/zynq_sdhci.c include/mmc.h+24 -220 replies
3/8mmc: zynq_sdhci: Move macro to the topdrivers/mmc/zynq_sdhci.c+2 -21 reply
4/8mmc: zynq_sdhci: Read clock phase delays from dtdrivers/mmc/zynq_sdhci.c+85 -01 reply
5/8mmc: zynq_sdhci: Set tapdelays based on clk phase delaysdrivers/mmc/zynq_sdhci.c+123 -51 reply
6/8mmc: zynq_sdhci: Add clock phase delays for Versaldrivers/mmc/zynq_sdhci.c+156 -41 reply
7/8mmc: zynq_sdhci: Extend UHS timings till hs200drivers/mmc/zynq_sdhci.c+1 -11 reply
8/8mmc: zynq_sdhci: Add common function to set input/output tapdelaysboard/xilinx/zynqmp/tap_delays.c include/zynqmp_tap_delay.h+36 -1590 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJaehoon ChungPeng Fan
1/8R-b R-b
2/8R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] mmc: zynqmp_sdhci: Add support for Tap delay

Hi,

this patchset adding support for Tap delay programming for ZynqMP and Versal.
Based on mainline discussion also DT properties have been introduced which are documented here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v5.7-rc6&id=fec81c5bca2499b4a263667860018c2ce47f4f51
The patchset is using these DT properties which are optional. Default values are also listed.

The patchset is based on:
https://lists.denx.de/pipermail/u-boot/2020-May/410326.html

Also new code is adding checking for SOCs which are not needed at that time when patch is applied (For example "mmc: zynq_sdhci: Read clock phase delays from dt" and IS_ENABLED(CONFIG_ARCH_ZYNQMP)...
But I kept it there for more cleaner patches built on the top.

Thanks,
Michal

Changes in v3:
- replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon
- replace host->version by SDHCI_GET_VERSION(host) reported by Jaehoon

Changes in v2:
- Timing macro's are common to all mmc drivers, hence remove zynq_sdhci from subject and description.
- Add common function to set tapdelays based on the values read from DT
- Remove tapdelay settings based on speed

Ashok Reddy Soma (6):
Revert "mmc: zynq: parse dt when probing"
mmc: Define timing macro's
mmc: zynq_sdhci: Set tapdelays based on clk phase delays
mmc: zynq_sdhci: Add clock phase delays for Versal
mmc: zynq_sdhci: Extend UHS timings till hs200
mmc: zynq_sdhci: Add common function to set input/output tapdelays

Michal Simek (2):
mmc: zynq_sdhci: Move macro to the top
mmc: zynq_sdhci: Read clock phase delays from dt

 board/xilinx/zynqmp/tap_delays.c | 199 +++------------
 drivers/mmc/sdhci.c              |   3 +-
 drivers/mmc/zynq_sdhci.c         | 406 +++++++++++++++++++++++++++++--
 include/mmc.h                    |  13 +
 include/sdhci.h                  |   1 +
 include/zynqmp_tap_delay.h       |   5 +-
 6 files changed, 434 insertions(+), 193 deletions(-)
Signature · 1 line
2.28.0