Skip to content

w1: omap: fix some regressions/bugs (some were introduced in v5.6 but some are older)

H. Nikolaus Schaller linux-omap lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4w1: omap-hdq: cleanup to add missing newline for some dev_dbgdrivers/w1/masters/omap_hdq.c+5 -51 reply
2/4w1: omap-hdq: fix return value to be -1 if there is a timeoutdrivers/w1/masters/omap_hdq.c+1 -11 reply
3/4w1: omap-hdq: fix interrupt handling which did show spurious timeoutsdrivers/w1/masters/omap_hdq.c+42 -201 reply
4/4w1: omap-hdq: print dev_err if irq flags are not cleareddrivers/w1/masters/omap_hdq.c+8 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchTony Lindgren
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] w1: omap: fix some regressions/bugs (some were introduced in v5.6 but some are older)

This series fixes:
* some dev_dbg are missing an explicit \n
* wrong return value if battery is removed and no hdq response
* problems with resetting interrupt flags too early leading to timeouts and wrong values
* print error if interrupt flags get mixed up

H. Nikolaus Schaller (4):
w1: omap-hdq: cleanup to add missing newline for some dev_dbg
w1: omap-hdq: fix return value to be -1 if there is a timeout
w1: omap-hdq: fix interrupt handling which did show spurious timeouts
w1: omap-hdq: print dev_err if irq flags are not cleared

 drivers/w1/masters/omap_hdq.c | 82 ++++++++++++++++++++++++-----------
 1 file changed, 56 insertions(+), 26 deletions(-)
Signature · 1 line
2.26.2