Skip to content

Fix segfault in lib/bpf.c

Andrea Claudi netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "bpf: replace snprintf with asprintf when dealing with long buffers"lib/bpf.c+39 -1160 replies
2/2bpf: Fixes a snprintf truncation warninglib/bpf.c+5 -10 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel Borkmann
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [iproute2 PATCH 0/2] Fix segfault in lib/bpf.c

Jamal reported a segfault in bpf_make_custom_path() when custom pinning is used. This is caused by commit c0325b06382cb ("bpf: replace snprintf with asprintf when dealing with long buffers").

As the only goal of that commit is to get rid of a truncation warning when compiling lib/bpf.c, revert it and fix the warning checking for snprintf return value

Andrea Claudi (2):
Revert "bpf: replace snprintf with asprintf when dealing with long
buffers"
bpf: Fixes a snprintf truncation warning

 lib/bpf.c | 155 +++++++++++++++---------------------------------------
 1 file changed, 41 insertions(+), 114 deletions(-)
Signature · 1 line
2.25.4