Skip to content

netlink interface update for 5.7 release

Michal Kubecek netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21netlink: fix build warningsnetlink/desc-ethtool.c netlink/parser.c+2 -21 reply
2/21netlink: fix nest type grouping in parsernetlink/parser.c+4 -41 reply
3/21netlink: fix msgbuff_append() helpernetlink/msgbuff.c+1 -01 reply
4/21update UAPI header copiesuapi/linux/ethtool.h uapi/linux/ethtool_netlink.h uapi/linux/if_link.h +1 more+193 -30 replies
5/21netlink: add more ethtool netlink message format descriptionsnetlink/desc-ethtool.c+127 -00 replies
6/21selftest: omit test-features if netlink is enabledMakefile.am+6 -20 replies
7/21netlink: add netlink handler for gfeatures (-k)Makefile.am common.c common.h +7 more+331 -550 replies
8/21netlink: add netlink handler for sfeatures (-K)ethtool.c netlink/bitset.c netlink/bitset.h +2 more+307 -50 replies
9/21netlink: add netlink handler for gprivflags (--show-priv-flags)Makefile.am ethtool.c netlink/extapi.h +3 more+122 -10 replies
10/21netlink: add netlink handler for sprivflags (--set-priv-flags)ethtool.c netlink/extapi.h netlink/privflags.c+53 -10 replies
11/21netlink: add netlink handler for gring (-g)Makefile.am ethtool.c netlink/extapi.h +3 more+96 -10 replies
12/21netlink: add netlink handler for sring (-G)ethtool.c netlink/extapi.h netlink/rings.c+74 -10 replies
13/21netlink: add netlink handler for gchannels (-l)Makefile.am ethtool.c netlink/channels.c +3 more+84 -00 replies
14/21netlink: add netlink handler for schannels (-L)ethtool.c netlink/channels.c netlink/extapi.h+74 -10 replies
15/21netlink: add netlink handler for gcoalesce (-c)Makefile.am ethtool.c netlink/coalesce.c +3 more+112 -10 replies
16/21netlink: add netlink handler for scoalesce (-C)ethtool.c netlink/coalesce.c netlink/extapi.h+182 -10 replies
17/21netlink: add netlink handler for gpause (-a)Makefile.am ethtool.c netlink/extapi.h +3 more+176 -10 replies
18/21netlink: add netlink handler for spause (-A)ethtool.c netlink/extapi.h netlink/pause.c+68 -10 replies
19/21netlink: add netlink handler for geee (--show-eee)Makefile.am ethtool.c netlink/eee.c +4 more+138 -140 replies
20/21netlink: add netlink handler for seee (--set-eee)ethtool.c netlink/eee.c netlink/extapi.h+85 -10 replies
21/21netlink: add netlink handler for tsinfo (-T)Makefile.am ethtool.c netlink/extapi.h +1 more+128 -10 replies

Reviews trailers per patch

None of the 21 patches has a Reviewed-by or Acked-by.

PatchAndrew LunnHeiko Thiery
1/21T-b
2/21T-b
3/21T-b
4/21
5/21
6/21
7/21
8/21
9/21
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH ethtool 00/21] netlink interface update for 5.7 release

This series adds supports for netlink interface features supported in kernel 5.7:

- get/set netdev features (-k / -K)
- get/set device private flags (--show-priv-flags / --set-priv-flags)
- get/set ring sizes (-g / -G)
- get/set channel counts (-l / -L)
- get/set coalescing parameters (-c / -C)
- get/set pause parameters (-a / -A)
- get/set EEE settings (--show-eee / --set-eee)
- get timestamping information (-T)

First three patches fix bugs found in existing code.

Michal Kubecek (21):
netlink: fix build warnings
netlink: fix nest type grouping in parser
netlink: fix msgbuff_append() helper
update UAPI header copies
netlink: add more ethtool netlink message format descriptions
selftest: omit test-features if netlink is enabled
netlink: add netlink handler for gfeatures (-k)
netlink: add netlink handler for sfeatures (-K)
netlink: add netlink handler for gprivflags (--show-priv-flags)
netlink: add netlink handler for sprivflags (--set-priv-flags)
netlink: add netlink handler for gring (-g)
netlink: add netlink handler for sring (-G)
netlink: add netlink handler for gchannels (-l)
netlink: add netlink handler for schannels (-L)
netlink: add netlink handler for gcoalesce (-c)
netlink: add netlink handler for scoalesce (-C)
netlink: add netlink handler for gpause (-a)
netlink: add netlink handler for spause (-A)
netlink: add netlink handler for geee (--show-eee)
netlink: add netlink handler for seee (--set-eee)
netlink: add netlink handler for tsinfo (-T)

 Makefile.am                  |  11 +-
 common.c                     |  30 ++
 common.h                     |  19 ++
 ethtool.c                    |  79 ++----
 netlink/bitset.c             |  31 +++
 netlink/bitset.h             |   2 +
 netlink/channels.c           | 141 ++++++++++
 netlink/coalesce.c           | 269 ++++++++++++++++++
 netlink/desc-ethtool.c       | 129 ++++++++-
 netlink/eee.c                | 189 +++++++++++++
 netlink/extapi.h             |  30 ++
 netlink/features.c           | 526 +++++++++++++++++++++++++++++++++++
 netlink/monitor.c            |  56 ++++
 netlink/msgbuff.c            |   1 +
 netlink/netlink.h            |  46 +++
 netlink/parser.c             |  10 +-
 netlink/pause.c              | 222 +++++++++++++++
 netlink/privflags.c          | 158 +++++++++++
 netlink/rings.c              | 141 ++++++++++
 netlink/settings.c           |  17 +-
 netlink/tsinfo.c             | 124 +++++++++
 uapi/linux/ethtool.h         |   9 +-
 uapi/linux/ethtool_netlink.h | 175 ++++++++++++
 uapi/linux/if_link.h         |   6 +-
 uapi/linux/net_tstamp.h      |   6 +
 25 files changed, 2347 insertions(+), 80 deletions(-)
 create mode 100644 netlink/channels.c
 create mode 100644 netlink/coalesce.c
 create mode 100644 netlink/eee.c
 create mode 100644 netlink/features.c
 create mode 100644 netlink/pause.c
 create mode 100644 netlink/privflags.c
 create mode 100644 netlink/rings.c
 create mode 100644 netlink/tsinfo.c
Signature · 1 line
2.26.2