selftests: forwarding: Two small changes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | selftests: forwarding: mirror_lib: Use mausezahntools/ | +2 | 0 replies | |
| 2/2 | selftests: forwarding: pedit_dsfield: Check counter valuetools/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 0/2] selftests: forwarding: Two small changes
Two unrelated changes in this patchset:
- In patch #1, convert mirror tests from using ping directly to generating ICMP packets by mausezahn. Using ping in tests is error-prone, because ping is too smart. On a flaky system (notably in a simulator), when packets don't come quickly enough, more pings are sent, and that throws off counters. This was worked around in the past by just pinging more slowly, but using mausezahn avoids the issue as well without making the tests unnecessary slow.
- A missing stats_update callback was recently added to act_pedit. Now that iproute2 supports JSON dumping for pedit, extend in patch #2 the pedit_dsfield selftest with a check that would have caught the fact that the callback was missing.
Petr Machata (2):
selftests: forwarding: mirror_lib: Use mausezahn
selftests: forwarding: pedit_dsfield: Check counter value
tools/testing/selftests/net/forwarding/mirror_lib.sh | 6 ++---- tools/testing/selftests/net/forwarding/pedit_dsfield.sh | 7 ++++++- 2 files changed, 8 insertions(+), 5 deletions(-)
Signature · 1 line
2.20.1