Skip to content

Mac ADB IOP driver fixes

Finn Thain linux-m68k linuxppc-dev lkml 1 version Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8macintosh/adb-iop: Remove dead and redundant codedrivers/macintosh/adb-iop.c+0 -290 replies
2/8macintosh/adb-iop: Correct comment textdrivers/macintosh/adb-iop.c+13 -160 replies
3/8macintosh/adb-iop: Adopt bus reset algorithm from via-macii driverdrivers/macintosh/adb-iop.c+8 -130 replies
4/8macintosh/adb-iop: Access current_req and adb_iop_state when inside lockdrivers/macintosh/adb-iop.c+5 -80 replies
5/8macintosh/adb-iop: Resolve static checker warningsdrivers/macintosh/adb-iop.c+7 -70 replies
6/8macintosh/adb-iop: Implement idle -> sending state transitiondrivers/macintosh/adb-iop.c+24 -190 replies
7/8macintosh/adb-iop: Implement sending -> idle state transitiondrivers/macintosh/adb-iop.c+3 -40 replies
8/8macintosh/adb-iop: Implement SRQ autopollingarch/m68k/include/asm/adb_iop.h drivers/macintosh/adb-iop.c+27 -66 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchStan JohnsonGeert Uytterhoeven
1/8T-b
2/8T-b
3/8T-b
4/8T-b
5/8T-b
6/8T-b
7/8T-b
8/8T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Mac ADB IOP driver fixes

The adb-iop driver was never finished. Some deficiencies have become apparent over the years. For example,

- Mouse and/or keyboard may stop working if used together

- SRQ autopoll list cannot be changed

- Some bugs were found by inspection

This patch series contains fixes for the known bugs in the driver, plus a few clean-ups.

Finn Thain (8):
macintosh/adb-iop: Remove dead and redundant code macintosh/adb-iop: Correct comment text macintosh/adb-iop: Adopt bus reset algorithm from via-macii driver macintosh/adb-iop: Access current_req and adb_iop_state when inside
lock
macintosh/adb-iop: Resolve static checker warnings macintosh/adb-iop: Implement idle -> sending state transition macintosh/adb-iop: Implement sending -> idle state transition macintosh/adb-iop: Implement SRQ autopolling

 arch/m68k/include/asm/adb_iop.h |   1 +
 drivers/macintosh/adb-iop.c     | 186 +++++++++++++++-----------------
 2 files changed, 86 insertions(+), 101 deletions(-)
Signature · 1 line
2.26.2