Skip to content

More sm501 fixes and optimisations

BALATON Zoltan qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 2 repliesIn review
  2. v28 patches 5 repliesSuperseded
  3. v14 patches 10 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9sm501: Fix bounds checkshw/display/sm501.c+4 -40 replies
2/9sm501: Drop unneded variablehw/display/sm501.c+2 -30 replies
3/9sm501: Ignore no-op blitshw/display/sm501.c+5 -00 replies
4/9sm501: Introduce variable for commonly used value for better readabilityhw/display/sm501.c+21 -200 replies
5/9sm501: Optimise 1 pixel 2d opshw/display/sm501.c+16 -30 replies
6/9sm501: Use stn_he_p/ldn_he_p instead of switch/casehw/display/sm501.c+1 -110 replies
7/9sm501: Do not allow guest to set invalid formathw/display/sm501.c+3 -00 replies
8/9sm501: Convert debug printfs to traceshw/display/sm501.c hw/display/trace-events+25 -370 replies
9/9sm501: Fix and optimize overlap checkhw/display/sm501.c+16 -105 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPhilippe Mathieu-Daudé
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/9] More sm501 fixes and optimisations

Version 3: added R-b tags and new patch to fix overlap checks. Hopefully I got it right this time, unless there are any more comments this should be good to go.

BALATON Zoltan (9):
sm501: Fix bounds checks
sm501: Drop unneded variable
sm501: Ignore no-op blits
sm501: Introduce variable for commonly used value for better
readability
sm501: Optimise 1 pixel 2d ops
sm501: Use stn_he_p/ldn_he_p instead of switch/case
sm501: Do not allow guest to set invalid format
sm501: Convert debug printfs to traces
sm501: Fix and optimize overlap check

 hw/display/sm501.c      | 157 +++++++++++++++++++---------------------
 hw/display/trace-events |  12 +++
 2 files changed, 87 insertions(+), 82 deletions(-)
Signature · 1 line
2.21.3