Skip to content

mptcp: fix some mp_join error paths

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mptcp: cache msk on MP_JOIN init_reqnet/mptcp/protocol.h net/mptcp/subflow.c+17 -220 replies
2/2mptcp: drop MP_JOIN request sock on syn cookiesnet/mptcp/subflow.c+10 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH 0/2] mptcp: fix some mp_join error paths

Currently we do not handle correctly MP_JOIN + syncookie and MP_JOIN failure due to passive socket being already closed.

First patch place the infrastructure needed, the 2nd one addresses the issues.
Note: in such error path, we will end-up creating the child socket just to reset the connection. I don't see an easy way to avoid such allocation and doing differently (reset on syn) could be dangerous (attacker can use the mptcp server to target a victim using spoofed bogus mp_join syn)

Paolo Abeni (2):
mptcp: cache msk on MP_JOIN init_req
mptcp: drop MP_JOIN request sock on syn cookies

 net/mptcp/protocol.h |  1 +
 net/mptcp/subflow.c  | 56 ++++++++++++++++++++------------------------
 2 files changed, 27 insertions(+), 30 deletions(-)
Signature · 1 line
2.21.3