Skip to content

net/cxgbe: fix rte_flow related hardware resource leaks

Rahul Lakkireddy dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net/cxgbe: fix CLIP leak in filter error pathdrivers/net/cxgbe/cxgbe_filter.c+31 -370 replies
2/5net/cxgbe: fix L2T leak in filter error and free pathdrivers/net/cxgbe/cxgbe_filter.c+16 -140 replies
3/5net/cxgbe: fix double MPS alloc due to flow validate and createdrivers/net/cxgbe/cxgbe_filter.c drivers/net/cxgbe/cxgbe_filter.h drivers/net/cxgbe/cxgbe_flow.c+38 -260 replies
4/5net/cxgbe: fix SMT leak in filter error and free pathdrivers/net/cxgbe/cxgbe_filter.c drivers/net/cxgbe/smt.c drivers/net/cxgbe/smt.h+21 -140 replies
5/5net/cxgbe: ignore flow default masks for unrequested fieldsdrivers/net/cxgbe/cxgbe_flow.c+74 -350 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 0/5] net/cxgbe: fix rte_flow related hardware resource leaks

This series of patches fix various hardware resource leaks in flow create failure and flow destroy paths.

Patch 1 fixes Compressed Local IP (CLIP) entry leaks.

Patch 2 fixes Layer 2 Table (L2T) entry leaks.

Patch 3 fixes double Multi Port Switch (MPS) entry allocations due to flow validate and create, but only freed once during flow destroy.

Patch 4 fixes Source MAC Table (SMT) entry leaks.

Patch 5 fixes flow validation errors seen due to default masks set for unrequested fields.

Thanks,
Rahul

Rahul Lakkireddy (5):
net/cxgbe: fix CLIP leak in filter error path net/cxgbe: fix L2T leak in filter error and free path net/cxgbe: fix double MPS alloc due to flow validate and create net/cxgbe: fix SMT leak in filter error and free path net/cxgbe: ignore flow default masks for unrequested fields

 drivers/net/cxgbe/cxgbe_filter.c | 158 ++++++++++++++++++-------------
 drivers/net/cxgbe/cxgbe_filter.h |   4 +-
 drivers/net/cxgbe/cxgbe_flow.c   | 137 +++++++++++++++------------
 drivers/net/cxgbe/smt.c          |   6 ++
 drivers/net/cxgbe/smt.h          |   1 +
 5 files changed, 180 insertions(+), 126 deletions(-)
Signature · 1 line
2.24.0