Skip to content

RFC Don't do tuning zigzag using the very same frequency

Mauro Carvalho Chehab linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4media: atomisp: fix identation at I2C Kconfig menudrivers/staging/media/atomisp/i2c/Kconfig drivers/staging/media/atomisp/i2c/ov5693/Kconfig+42 -440 replies
2/4media: atomisp: fix help message for ISP2401 selectiondrivers/staging/media/atomisp/Kconfig+1 -10 replies
3/4media: dvb_frontend: move algo-specific settings to a functiondrivers/media/dvb-core/dvb_frontend.c+49 -411 reply
4/4media: dvb_frontend: disable zigzag mode if not possibledrivers/media/dvb-core/dvb_frontend.c+79 -623 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchMarc Gonzalez
1/4
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/4] Don't do tuning zigzag using the very same frequency

Marc reported on IRC that the zigzag code is trying to tune several times using the same frequency with si2168. Well, this is not how this would be supposed to do: it should try with different frequencies each time.

Change the core to use the one-shot mode if the frontend doesn't report a frequency step. This will default to the current behavior, except that tuning should be faster.

Yet, probably the right thing to do is to implement a frequency shift at such frontends, as otherwise tuning may have problems. So, produce a warning on such cases, in order for the FE driver to be fixed.

Mauro Carvalho Chehab (4):
media: atomisp: fix identation at I2C Kconfig menu
media: atomisp: fix help message for ISP2401 selection
media: dvb_frontend: move algo-specific settings to a function
media: dvb_frontend: disable zigzag mode if not possible

 drivers/media/dvb-core/dvb_frontend.c         | 231 ++++++++++--------
 drivers/staging/media/atomisp/Kconfig         |   2 +-
 drivers/staging/media/atomisp/i2c/Kconfig     |  74 +++---
 .../staging/media/atomisp/i2c/ov5693/Kconfig  |  12 -
 4 files changed, 171 insertions(+), 148 deletions(-)
 delete mode 100644 drivers/staging/media/atomisp/i2c/ov5693/Kconfig
Signature · 1 line
2.26.2