test/kms_cursor_crc: tie some loose ends in prepare_crtc
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest1 patch 1 replyIn review
- v12 patches 4 repliesSuperseded
Changes in v2 from the cover letter
- Rebase 1st patch on master
- Drop the 2nd patch
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | test/kms_cursor_crc: release old pipe_crc before create a new onetests/ | +2 | 1 reply |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Arkadiusz Hiler |
|---|---|
| 1/1 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t v2 0/1] test/kms_cursor_crc: tie some loose ends in prepare_crtc
Hi,
Using vkms, when running a sequence of subtests from kms_cursor_crc, several strange timeout failures occurred. For example, running the alpha-opaque cursor twice, the first run is successful and the second fails. In addition, if we run the entire test in a call (i.e.: sudo IGT_FORCE_DRIVER=vkms build/tests/kms_cursor_crc), the first subtest passes and the rest of the subtests fail - even those that succeed when run in isolation.
igt_debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
igt_core-INFO: Timed out: Opening crc fd, and poll for first CRC.
During my debugging process, I found two issues that were blocking execution:
1 - When a subtest fails, it exits and skips the cleaning step, leaving the pipe_crc allocated and blocked for the next subtest; the following patch addresses it by releasing any old pipe_crc before creating a new one.
2 - When the CRC capture process starts, it enters an endless wait; in the previous version, I thought it was a matter of timing in test using vkms, but after further investigation, other problems arise in the same subject and I am dropping the 2nd patch to better solve the problem on the vkms side.
Changes in v2:
- Rebase 1st patch on master
- Drop the 2nd patch
Melissa Wen (1):
test/kms_cursor_crc: release old pipe_crc before create a new one
tests/kms_cursor_crc.c | 2 ++ 1 file changed, 2 insertions(+)
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev