Skip to content

cxgb4/cxgb4vf: fix warnings reported by sparse

Rahul Lakkireddy netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12cxgb4: move handling L2T ARP failures to callerdrivers/net/ethernet/chelsio/cxgb4/l2t.c+24 -280 replies
2/12cxgb4: move PTP lock and unlock to caller in Tx pathdrivers/net/ethernet/chelsio/cxgb4/sge.c+11 -120 replies
3/12cxgb4: use unaligned conversion for fetching timestampdrivers/net/ethernet/chelsio/cxgb4/sge.c+1 -10 replies
4/12cxgb4: parse TC-U32 key values and masks nativelydrivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h+91 -490 replies
5/12cxgb4: fix endian conversions for L4 ports in filtersdrivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c+22 -250 replies
6/12cxgb4: use correct type for all-mask IP address comparisondrivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c+5 -50 replies
7/12cxgb4: fix SGE queue dump destination buffer contextdrivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c+4 -20 replies
8/12cxgb4: remove cast when saving IPv4 partial checksumdrivers/net/ethernet/chelsio/cxgb4/sge.c+1 -20 replies
9/12cxgb4: move DCB version extern to header filedrivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c+3 -10 replies
10/12cxgb4: fix set but unused variable when DCB is disableddrivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c+3 -30 replies
11/12cxgb4: update kernel-doc line commentsdrivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c +5 more+38 -300 replies
12/12cxgb4vf: update kernel-doc line commentsdrivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c drivers/net/ethernet/chelsio/cxgb4vf/sge.c drivers/net/ethernet/chelsio/cxgb4vf/t4vf_hw.c+8 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 00/12] cxgb4/cxgb4vf: fix warnings reported by sparse

This series of patches fix various warnings reported by the sparse tool.

Patches 1 and 2 fix lock context imbalance warnings.

Patch 3 fixes cast to restricted __be64 warning when fetching timestamp in PTP path.

Patch 4 fixes several cast to restricted __be32 warnings in TC-U32 offload parser.

Patch 5 fixes several cast from restricted __be16 warnings in parsing L4 ports for filters.

Patch 6 fixes several restricted __be32 degrades to integer warnings when comparing IP address masks for exact-match filters.

Patch 7 fixes cast to restricted __be64 warning when fetching SGE queue contexts in device dump collection.

Patch 8 fixes cast from restricted __sum16 warning when saving IPv4 partial checksum.

Patch 9 fixes issue with string array scope in DCB path.

Patch 10 fixes a set but unused variable warning when DCB is disabled.

Patch 11 fixes several kernel-doc comment warnings in cxgb4 driver.

Patch 12 fixes several kernel-doc comment warnings in cxgb4vf driver.

Thanks,
Rahul

Rahul Lakkireddy (12):
cxgb4: move handling L2T ARP failures to caller
cxgb4: move PTP lock and unlock to caller in Tx path
cxgb4: use unaligned conversion for fetching timestamp
cxgb4: parse TC-U32 key values and masks natively
cxgb4: fix endian conversions for L4 ports in filters
cxgb4: use correct type for all-mask IP address comparison
cxgb4: fix SGE queue dump destination buffer context
cxgb4: remove cast when saving IPv4 partial checksum
cxgb4: move DCB version extern to header file
cxgb4: fix set but unused variable when DCB is disabled
cxgb4: update kernel-doc line comments
cxgb4vf: update kernel-doc line comments

 .../net/ethernet/chelsio/cxgb4/cudbg_lib.c    |   6 +-
 .../net/ethernet/chelsio/cxgb4/cxgb4_dcb.h    |   3 +
 .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c    |   1 -
 .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |   2 +-
 .../net/ethernet/chelsio/cxgb4/cxgb4_filter.c |  25 ++--
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  11 +-
 .../net/ethernet/chelsio/cxgb4/cxgb4_ptp.c    |   3 +-
 .../ethernet/chelsio/cxgb4/cxgb4_tc_flower.c  |  30 ++---
 .../net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c |  18 +--
 .../chelsio/cxgb4/cxgb4_tc_u32_parse.h        | 122 ++++++++++++------
 drivers/net/ethernet/chelsio/cxgb4/l2t.c      |  53 ++++----
 drivers/net/ethernet/chelsio/cxgb4/sched.c    |   2 +-
 drivers/net/ethernet/chelsio/cxgb4/sge.c      |  47 +++----
 drivers/net/ethernet/chelsio/cxgb4/smt.c      |   2 +
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c    |  36 +++---
 .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |   3 +-
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c    |   7 +-
 .../net/ethernet/chelsio/cxgb4vf/t4vf_hw.c    |   9 +-
 18 files changed, 211 insertions(+), 169 deletions(-)
Signature · 1 line
2.24.0