Skip to content

mptcp: msk diag support

Paolo Abeni mptcp 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 posting 2/22 patches 0 repliesNew
  2. v3 Latest4 patches 4 repliesIn review
  3. v2 posting 1/24 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v3 from the cover letter

- changed token iterator APIs: use RCU && get_sock
- tests cleanup

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4inet_diag: support for wider protocol numbersinclude/uapi/linux/inet_diag.h net/core/sock.c net/ipv4/inet_diag.c+48 -170 replies
2/4mptcp: add msk interations helpernet/mptcp/protocol.h net/mptcp/token.c+61 -00 replies
3/4mptcp: add MPTCP socket diag interfaceinclude/uapi/linux/mptcp.h net/mptcp/Kconfig net/mptcp/Makefile +1 more+192 -00 replies
4/4selftests/mptcp: add diag interface teststools/testing/selftests/net/mptcp/Makefile tools/testing/selftests/net/mptcp/diag.sh tools/testing/selftests/net/mptcp/mptcp_connect.c+141 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [MPTCP] [PATCH v3 0/4] mptcp: msk diag support

This introduces basic mptcp sockets diag support.
As IPPROTO_MPTCP excedes 8 bits, we need some changes at the inet_diag level:
a new attribute is introduced to allow user-space providing u32 protocol values.

Patch 2 introduces new token APIs to allow traversing the existing msks, while patch 3 bring in the actual diag implementation.

Patch 4 includes some basic functional tests

v2 -> v3:
- changed token iterator APIs: use RCU && get_sock
- tests cleanup

v1 -> v2
- fixed dump issue on large dump
- use flags for fallback, etc
- patch 4

Paolo Abeni (4):
inet_diag: support for wider protocol numbers
mptcp: add msk interations helper
mptcp: add MPTCP socket diag interface
selftests/mptcp: add diag interface tests

 include/uapi/linux/inet_diag.h                |   1 +
 include/uapi/linux/mptcp.h                    |  17 ++
 net/core/sock.c                               |   1 +
 net/ipv4/inet_diag.c                          |  63 +++++--
 net/mptcp/Kconfig                             |   4 +
 net/mptcp/Makefile                            |   2 +
 net/mptcp/mptcp_diag.c                        | 169 ++++++++++++++++++
 net/mptcp/protocol.h                          |   2 +
 net/mptcp/token.c                             |  59 ++++++
 tools/testing/selftests/net/mptcp/Makefile    |   2 +-
 tools/testing/selftests/net/mptcp/diag.sh     | 122 +++++++++++++
 .../selftests/net/mptcp/mptcp_connect.c       |  22 ++-
 12 files changed, 442 insertions(+), 22 deletions(-)
 create mode 100644 net/mptcp/mptcp_diag.c
 create mode 100755 tools/testing/selftests/net/mptcp/diag.sh
Signature · 1 line
2.26.2