cxgb4: add mirror action support for TC-MATCHALL
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 2 repliesIn review
- v23 patches 1 replySuperseded
- v13 patches 9 repliesSuperseded
Changes in v3 from the cover letter
- Replace mirror VI refcount_t with normal u32 variable in all patches.
- Add back calling cxgb4_port_mirror_start() in cxgb_open(), which was there in v1, but got missed in v2 during refactoring, in patch 3.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | cxgb4: add mirror action to TC-MATCHALL offloaddrivers/ drivers/ drivers/ +4 more | +197 | 0 replies | |
| 2/3 | cxgb4: add support for mirror Rxqsdrivers/ drivers/ drivers/ | +288 | 0 replies | |
| 3/3 | cxgb4: add main VI to mirror VI config replicationdrivers/ drivers/ drivers/ | +121 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jakub Kicinski |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 0/3] cxgb4: add mirror action support for TC-MATCHALL
This series of patches add support to mirror all ingress traffic for TC-MATCHALL ingress offload.
Patch 1 adds support to dynamically create a mirror Virtual Interface (VI) that accepts all mirror ingress traffic when mirror action is set in TC-MATCHALL offload.
Patch 2 adds support to allocate mirror Rxqs and setup RSS for the mirror VI.
Patch 3 adds support to replicate all the main VI configuration to mirror VI. This includes replicating MTU, promiscuous mode, all-multicast mode, and enabled netdev Rx feature offloads.
Thanks,
Rahul
v3:
- Replace mirror VI refcount_t with normal u32 variable in all patches.
- Add back calling cxgb4_port_mirror_start() in cxgb_open(), which was there in v1, but got missed in v2 during refactoring, in patch 3.
v2:
- Add mutex to protect all mirror VI data, instead of just mirror Rxqs, in patch 1 and 2.
- Remove the un-needed mirror Rxq mutex in patch 2.
- Simplify the replication code by refactoring t4_set_rxmode() to handle mirror VI, instead of duplicating the t4_set_rxmode() calls in multiple places in patch 3.
Rahul Lakkireddy (3):
cxgb4: add mirror action to TC-MATCHALL offload
cxgb4: add support for mirror Rxqs
cxgb4: add main VI to mirror VI config replication
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 24 +- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 66 ++- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 445 ++++++++++++++++-- .../ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 16 +- .../ethernet/chelsio/cxgb4/cxgb4_tc_flower.h | 3 +- .../chelsio/cxgb4/cxgb4_tc_matchall.c | 57 ++- .../chelsio/cxgb4/cxgb4_tc_matchall.h | 1 + drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 43 +- 8 files changed, 606 insertions(+), 49 deletions(-)
Signature · 1 line
2.24.0