Skip to content

RFC 8390: core cleanup

Armin Wolf netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib8390: Miscellaneous cleanupsdrivers/net/ethernet/8390/lib8390.c+279 -3060 replies
2/28390: Miscellaneous cleanupsdrivers/net/ethernet/8390/8390.c+20 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2 net-next] 8390: core cleanup

The purpose of this patchset is to do some cleanups in lib8390.c.

While most cleanups are simple checkpatch warnings, some unnecessary librarys where also removed, reducing the library size by ~4kb.

Functional changes include the removal of all module-related stuff from the library to prevent conflicts with real modules using lib8390, which requires changes in modules depending on the module-related stuff and the unnecessary librarys.

Basically all modules directly including lib8390 need to be checked for missing librarys/msg_enable params, but so far only 8390.c has been modified to support the cleaned-up lib8390.
And since 8390.c is not a full nic driver, the missing param was omited.

All patches compile successfully and appear to function normaly under 5.8.0-rc2 and a RTL8029AS card.

Armin Wolf (2):
lib8390: Miscellaneous cleanups
8390: Miscellaneous cleanups

 drivers/net/ethernet/8390/8390.c    |  25 +-
 drivers/net/ethernet/8390/lib8390.c | 585 +++++++++++++---------------
 2 files changed, 299 insertions(+), 311 deletions(-)

--
2.20.1