Skip to content

Fix races on device removal

Lukas Wunner linux-spi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3driver core: Avoid binding drivers to dead devicesdrivers/base/dd.c+3 -10 replies
2/3driver core: Use rwsem for kill_device() serializationdrivers/base/base.h drivers/base/core.c drivers/base/dd.c +1 more+30 -214 replies
3/3driver core: Avoid adding children below a dead parentdrivers/base/core.c drivers/spi/spi.c+19 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix races on device removal

Prevent dynamic SPI device addition below a controller which is being removed. To do so, set the controller's "dead" flag using kill_device() (patch [3/3]).

Serialize access to a device's "dead" flag with a newly introduced rw_semaphore in lieu of the device_lock to avoid deadlocks occurring with the new use case (patch [2/3]).

Add a missing check for the "dead" flag upon driver binding (patch [1/3]).

Lukas Wunner (3):
driver core: Avoid binding drivers to dead devices driver core: Use rwsem for kill_device() serialization driver core: Avoid adding children below a dead parent

 drivers/base/base.h  |  2 ++
 drivers/base/core.c  | 49 ++++++++++++++++++++++++++++++--------------
 drivers/base/dd.c    | 12 ++++++++++-
 drivers/nvdimm/bus.c |  8 +-------
 drivers/spi/spi.c    |  3 +++
 5 files changed, 51 insertions(+), 23 deletions(-)
Signature · 1 line
2.27.0