Skip to content

mlxsw: Add support for buffer drops mirroring

Petr Machata netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest13 patches 3 repliesIn review

Changes in v2 from the cover letter

- Patch #1:
- In struct flow_block_indr, track both sch and dev.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13net: sched: Pass qdisc reference in struct flow_block_offloaddrivers/net/ethernet/broadcom/bnxt/bnxt_tc.c drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c drivers/net/ethernet/netronome/nfp/flower/main.h +6 more+38 -322 replies
2/13mlxsw: reg: Add Monitoring Mirror Trigger Enable Registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+50 -00 replies
3/13mlxsw: reg: Add Monitoring Port Analyzer Global Registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+52 -00 replies
4/13mlxsw: spectrum_span: Move SPAN operations out of global filedrivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c +1 more+55 -510 replies
5/13mlxsw: spectrum_span: Prepare for global mirroring triggersdrivers/net/ethernet/mellanox/mlxsw/spectrum_span.c drivers/net/ethernet/mellanox/mlxsw/spectrum_span.h+103 -170 replies
6/13mlxsw: spectrum_span: Add support for global mirroring triggersdrivers/net/ethernet/mellanox/mlxsw/spectrum_span.c drivers/net/ethernet/mellanox/mlxsw/spectrum_span.h+104 -30 replies
7/13mlxsw: spectrum_span: Add APIs to enable / disable global mirroring triggersdrivers/net/ethernet/mellanox/mlxsw/spectrum_span.c drivers/net/ethernet/mellanox/mlxsw/spectrum_span.h+139 -00 replies
8/13mlxsw: spectrum_flow: Convert a goto to a returndrivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c+1 -30 replies
9/13mlxsw: spectrum_flow: Drop an unused fielddrivers/net/ethernet/mellanox/mlxsw/spectrum.h+0 -10 replies
10/13mlxsw: spectrum_matchall: Publish matchall data structuresdrivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum_matchall.c+24 -230 replies
11/13mlxsw: spectrum_flow: Promote binder-type dispatch to spectrum.cdrivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c+19 -130 replies
12/13mlxsw: spectrum_qdisc: Offload mirroring on RED qevent early_dropdrivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c+476 -00 replies
13/13selftests: mlxsw: RED: Test offload of mirror on RED early_drop qeventtools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh tools/testing/selftests/drivers/net/mlxsw/sch_red_ets.sh tools/testing/selftests/drivers/net/mlxsw/sch_red_root.sh+122 -30 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoPetr Machata
1/13
2/13R-b R-b
3/13R-b R-b
4/13R-b R-b
5/13R-b R-b
6/13R-b R-b
7/13R-b R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 00/13] mlxsw: Add support for buffer drops mirroring

This set offloads the recently introduced qevent infrastructure in TC and allows mlxsw to support mirroring of packets that were dropped due to buffer related reasons (e.g., early drops) during forwarding.

Up until now mlxsw only supported mirroring that was either triggered by per-port triggers (i.e., via matchall) or by the policy engine (i.e., via flower). Packets that are dropped due to buffer related reasons are mirrored using a third type of trigger, a global trigger.

Global triggers are bound once to a mirroring (SPAN) agent and enabled on a per-{port, TC} basis. This allows users, for example, to request that only packets that were early dropped on a specific netdev to be mirrored.

Patch set overview:

Patch #1 extends flow_block_offload and indirect offload structure to pass a scheduler instead of a netdevice. That is necessary, because binding type and netdevice are not a unique identifier of the block anymore.

Patches #2-#3 add the required registers to support above mentioned functionality.

Patches #4-#6 gradually add support for global mirroring triggers.

Patch #7 adds support for enablement of global mirroring triggers.

Patches #8-#11 are cleanups in the flow offload code and shuffle some code around to make the qevent offload easier.

Patch #12 implements offload of RED early_drop qevent.

Patch #13 extends the RED selftest for offloaded datapath to cover early_drop qevent.

v2:
- Patch #1:
- In struct flow_block_indr, track both sch and dev.

Amit Cohen (2):
mlxsw: reg: Add Monitoring Mirror Trigger Enable Register
mlxsw: reg: Add Monitoring Port Analyzer Global Register

Ido Schimmel (4):
mlxsw: spectrum_span: Move SPAN operations out of global file
mlxsw: spectrum_span: Prepare for global mirroring triggers
mlxsw: spectrum_span: Add support for global mirroring triggers
mlxsw: spectrum_span: Add APIs to enable / disable global mirroring
triggers

Petr Machata (7):
net: sched: Pass qdisc reference in struct flow_block_offload
mlxsw: spectrum_flow: Convert a goto to a return
mlxsw: spectrum_flow: Drop an unused field
mlxsw: spectrum_matchall: Publish matchall data structures
mlxsw: spectrum_flow: Promote binder-type dispatch to spectrum.c
mlxsw: spectrum_qdisc: Offload mirroring on RED qevent early_drop
selftests: mlxsw: RED: Test offload of mirror on RED early_drop qevent

 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c  |   9 +-
 .../ethernet/mellanox/mlx5/core/en/rep/tc.c   |  10 +-
 drivers/net/ethernet/mellanox/mlxsw/reg.h     | 102 ++++
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  65 +--
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |  33 +-
 .../ethernet/mellanox/mlxsw/spectrum_flow.c   |  18 +-
 .../mellanox/mlxsw/spectrum_matchall.c        |  23 -
 .../ethernet/mellanox/mlxsw/spectrum_qdisc.c  | 472 ++++++++++++++++++
 .../ethernet/mellanox/mlxsw/spectrum_span.c   | 397 ++++++++++++++-
 .../ethernet/mellanox/mlxsw/spectrum_span.h   |  16 +
 .../net/ethernet/netronome/nfp/flower/main.h  |   2 +-
 .../ethernet/netronome/nfp/flower/offload.c   |   8 +-
 include/net/flow_offload.h                    |   9 +-
 net/core/flow_offload.c                       |  12 +-
 net/netfilter/nf_flow_table_offload.c         |   2 +-
 net/netfilter/nf_tables_offload.c             |   2 +-
 net/sched/cls_api.c                           |  16 +-
 .../drivers/net/mlxsw/sch_red_core.sh         | 106 +++-
 .../drivers/net/mlxsw/sch_red_ets.sh          |  11 +
 .../drivers/net/mlxsw/sch_red_root.sh         |   8 +
 20 files changed, 1179 insertions(+), 142 deletions(-)
Signature · 1 line
2.20.1